From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F396C282C4 for ; Mon, 4 Feb 2019 21:46:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5AA1C20844 for ; Mon, 4 Feb 2019 21:46:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gq9povbp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730438AbfBDVqB (ORCPT ); Mon, 4 Feb 2019 16:46:01 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:50624 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727894AbfBDVqA (ORCPT ); Mon, 4 Feb 2019 16:46:00 -0500 Received: by mail-wm1-f66.google.com with SMTP id z5so1510481wmf.0 for ; Mon, 04 Feb 2019 13:45:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2kiMi4hH9m1FO0S8epb4+DDqDzsYe84789GzVqpeSjw=; b=gq9povbpdeRixLgr7NtwImExUy/mOuDLKtCgYykubqydS8Mq5dbkMEDMtIxV0JqeLn ppIwf7w3YFHFyH9lqnFOP+6bJT6+esr52aCwmHuQ8KsPwfJ42R9D4eW9Vpx6L2dJU/w1 jIn5oAlqVuXDtL+iRTmm7lpgJ9nXYGGkaCPRM6wRUPItNeFFlDDSNOP0Fvx5QDwLP3hf tBmwXMtbK5ck/SXRguEiFMdFxX86BgF/GLQRTo8xNkNWJibTUALGeA2qCInqVc2fSS9o NHry3DNWEqy+UekjzZokudrvLydsZlAeMFoRsHySOrlEebl73zaSXCVLuc4haUyy8mP8 l9Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2kiMi4hH9m1FO0S8epb4+DDqDzsYe84789GzVqpeSjw=; b=IxpcCDNOnfrjAyCundHWV6df02SRA4uFM4Bk61TglKG4p887Y3EhopVUH8SALLInOT /rtsafb7Tdq8G1TKUW9c1Ra/pWcdEj8dvXJ5eIYcphYPvmrdkZAQwWfz3fd+2Lrfd21S zNgZarrvUflHUowMaL1fYYWScJF9H84lCEk00fxPIDN4a/3I7PXDNnH4tCChVsWM2R6t DmONn3q+nJR5VyNfAQqNVb5Pt+AYknz8ecmB7dD7OMU5CmLUxka5hneCTurNKnAFeu+1 6AL7g+XHm8GG6Q/m/HgpwDi/0d/LugJ6GdbIz4XvjtZCqSgLeMP9MbuJ/2owB2hiSCyp cH7Q== X-Gm-Message-State: AHQUAuY+BfNf0nX9OaxCt501w556VugCO96a8fPfm4RcT8cuK3+7H3EL VKF2RbP48YUW4bWJZAbtWJiXQlDQ X-Google-Smtp-Source: AHgI3IZeJXmdDtytPEXlq4HSRYB4L9Xqe1Ni/jNQUcPsddJAlNc2khPCawdTjSevBMSaBbWFZ+l6Yw== X-Received: by 2002:a1c:4855:: with SMTP id v82mr1033140wma.15.1549316758109; Mon, 04 Feb 2019 13:45:58 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:79d1:9f16:256f:82a8? (p200300EA8BF1E20079D19F16256F82A8.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:79d1:9f16:256f:82a8]) by smtp.googlemail.com with ESMTPSA id a14sm3270337wrh.47.2019.02.04.13.45.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 13:45:57 -0800 (PST) Subject: Re: [PATCH 1/3 net-next] net: phy: aquantia: improve setting speed and duplex in aqr_read_status To: Andrew Lunn Cc: Florian Fainelli , David Miller , Nikita Yushchenko , "netdev@vger.kernel.org" References: <8e41695d-a23e-adad-ae3d-66a46d1ab077@gmail.com> <20190204212832.GB3397@lunn.ch> From: Heiner Kallweit Message-ID: Date: Mon, 4 Feb 2019 22:45:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190204212832.GB3397@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 04.02.2019 22:28, Andrew Lunn wrote: > On Mon, Feb 04, 2019 at 10:03:21PM +0100, Heiner Kallweit wrote: >> Add support for speeds 10Mbps, 5Gbps, and 10Gbps. In addition don't >> hardcode duplex but read it from the chip. > > Hi Heiner > > The marvell10g does this differently. It gets the local and link > partner advertised link modes and from that works out what the PHY is > doing. If auto-neg is not being used, it then reads the link speed > from the PMA. > Right, it's the same mechanism we use in genphy_read_status() for clause 22. > The question is, should the Aquantia PHY do the same, or should it > look an vendor registers? Apart from getting the 1G advertisement, all > the Marvell code uses generic registers. So we should be able to move > most of it into phy-c45 and reuse it. That is what i would prefer. > I'd like to use standard registers wherever possible. This patch is meant as a quick win to improve what we do already in aqr_read_status. Once we have a generic c45 read_status function we should switch to it. However I assume that information like interface mode we still have to read from vendor registers. > Andrew > Heiner