From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Anas Iqbal <mohd.abd.6602@gmail.com>, jonas.gorski@gmail.com
Cc: andrew@lunn.ch, olteanv@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: dsa: bcm_sf2: fix missing clk_disable_unprepare() in error paths
Date: Mon, 16 Mar 2026 16:17:24 -0700 [thread overview]
Message-ID: <d6d952fe-499a-4863-99f4-3f761284aa1e@broadcom.com> (raw)
In-Reply-To: <20260316132547.1274-1-mohd.abd.6602@gmail.com>
On 3/16/26 06:25, Anas Iqbal wrote:
> Smatch reports:
> drivers/net/dsa/bcm_sf2.c:997 bcm_sf2_sw_resume() warn:
> 'priv->clk' from clk_prepare_enable() not released on lines: 983,990.
>
> The clock enabled by clk_prepare_enable() in bcm_sf2_sw_resume()
> is not released if bcm_sf2_sw_rst() or bcm_sf2_cfp_resume() fails.
>
> Add the missing clk_disable_unprepare() calls in the error paths
> to properly release the clock resource.
>
> Fixes: e9ec5c3bd238 ("net: dsa: bcm_sf2: request and handle clocks")
> Reviewed-by: Jonas Gorski <jonas.gorski@gmail.com>
> Signed-off-by: Anas Iqbal <mohd.abd.6602@gmail.com>
Subject should be "PATCH net", and you would want to wait 24 hrs before
re-submitting, with that:
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2026-03-16 23:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 8:11 [PATCH] net: dsa: bcm_sf2: fix missing clk_disable_unprepare() in error paths Anas Iqbal
2026-03-16 7:06 ` Jonas Gorski
2026-03-16 13:25 ` Anas Iqbal
2026-03-16 23:17 ` Florian Fainelli [this message]
2026-03-16 23:56 ` Jakub Kicinski
2026-03-18 8:42 ` [PATCH net v3] " Anas Iqbal
2026-03-19 16:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6d952fe-499a-4863-99f4-3f761284aa1e@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonas.gorski@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohd.abd.6602@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox