From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D94692063F3 for ; Thu, 13 Feb 2025 05:26:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739424376; cv=none; b=C+cB87a0EN90ADLDYksNL4PvZk7eu0P5GNwfnSU8n/dRnhdep4FY4UvK2KpEq47kB1wDes5ucpKIirxQxUePa/Tf0ek49wI4j0r8zF1wra+tT1pDKaNZTRkBQEW+23b4R1gU11QVtaNh45QKg4u3w7UwmP1TCQY+ws/+bh4YqcI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739424376; c=relaxed/simple; bh=t6YR0npYVjRvyKj0ZE1XLCJjmwLZGXa/7c4my+oO014=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bj36of1/pp+jGw5DYW0mDxdzw5uyLShBtkXsJSJqzLv3L8pB6T776RB3XnkmkD66HoMAd+31tI5tp5HSwigJOH+/sSl1FNupGEfo9vbzrrlO/09oYxTrbXJz81GaaJperaIpJSnSc0lj5/BexxSjT2cOFqUGeYuDpBUIcOARR8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JXV8gn2U; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JXV8gn2U" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5dec817f453so680635a12.2 for ; Wed, 12 Feb 2025 21:26:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739424373; x=1740029173; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0HAEYUoXN1RzPu9Vc5RFXNu3L5U0k8+uT71SbgN/hXA=; b=JXV8gn2UZhGegF7+LPmcwR/bRPnsW9fAJzgvT4gqFCIX04Ux2Oek21eAK5biQR5/4V OjJRN2ha+0CUdpOUZZgFlEpnDUrUXwHVvnUgpz5BNYSsKWw5hvoXC0BQ8Kx4ImGBz+dc 15bK/+8mTYV/0C38jLwQ1p0bgRqluAJ8lzaXfrYV9bsS27a6vcqFrtdWoeP0tmO6JAaB PHHszoU6y+dx9bA82OOMBGSPILMrjtqdx2/AseUuZNhfUPfWD3hb1egs6rAnGKoJpEmT awDRzlNaxo5o4Y1IeFAunzpAIt6+yolsLIOcU8xfO0DNNTxlTHioETVOtHZvl4fFlQhI /Y6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739424373; x=1740029173; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0HAEYUoXN1RzPu9Vc5RFXNu3L5U0k8+uT71SbgN/hXA=; b=IdL6yuUXDxwqaV2fyR69RejTwM318GZiDYGKMrJfnrzYpysRDGHzFCt3SY1BLMRo1k /SSeSMLW4H8368jLXY8Z703ix9K4vmp6PO3g3N+SzLjbLwrHnpa9RIaTUy0wXlWYXBlM npmPT81p9+4y8E1DwDxm1Gm6AfbaB98jxcEhKRT/9MGUn1yxG9fxwobOALd7EUxItQLI IQ8LRaJiKQq4AZdYIuBA5w1Ceo0jZopN3MUEstyyA4FLVX+px7szd9LJhTsrHFMDVeFz NzuGORh+KN52KMkCLVzVB+5y4FhOcnSti1QxfQCCAY2n2Agjwr2r6/4ums6SGRspH74F hMAw== X-Forwarded-Encrypted: i=1; AJvYcCXx1maU/dnlwsY13fy0i4XweLh/wiz9g4KmvIj+jMRmuCkyBhharom6jTTXXK2oiqKfJ+bCAw8=@vger.kernel.org X-Gm-Message-State: AOJu0YwmqTICVQsWQW9xP7yGZYE1UHqyQ5veMyQEvBcJTa5kfNb+a9wT uhpCQiNo2EBUVB64h5uZpjIaGlssRw8QGgUBNWWFMHJBRfSQ1LJGN9KZUU+IcOvQDQUrGALR9Ul j X-Gm-Gg: ASbGncvWgcal4wMnt14zUZZVtCYziNEUacdE51EgJx4cgkSACRVweLv0sgqcGqOgaHw sOjv0te6aTMhlrVE+L0k0OZDUWRv3BZkFsOEEnkNUtfeWte8pcsCnqq3oxsmnDSmDpp7Ozj/NMu PABkuIDsfGP/5R1ZtzdGv6i0DzRzr76CqOycs3w7XTuTCiWmzFCEjnZi+Bc/xo3c4nlD6SMEtXq +sBgxDhc5SwSrY6bG5B/lEx2bxwTL9LJoHZLxwlyunWdfqTnD9vXMeQ/8JPClFSq3PdzBJykBAz gXJYJ6otvjP7mRDd0HRt X-Google-Smtp-Source: AGHT+IEzj9Ta5BdBT6AH7PreThdj8+Vp0LN+dbci6CqGFf6XXQjsFFpLhPxNkTgcclST41hSlPWi8A== X-Received: by 2002:a17:906:7956:b0:ab7:f221:f7b4 with SMTP id a640c23a62f3a-ab7f34738c0mr544342766b.43.1739424373199; Wed, 12 Feb 2025 21:26:13 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-aba53257618sm55687766b.51.2025.02.12.21.26.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 21:26:12 -0800 (PST) Date: Thu, 13 Feb 2025 08:26:09 +0300 From: Dan Carpenter To: Jakub Kicinski Cc: Alexander Lobakin , Michal Swiatkowski , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jacob Keller , Wojciech Drewek , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH next] ice: Fix signedness bug in ice_init_interrupt_scheme() Message-ID: References: <14ebc311-6fd6-4b0b-b314-8347c4efd9fc@stanley.mountain> <20250212175901.11199ce1@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250212175901.11199ce1@kernel.org> On Wed, Feb 12, 2025 at 05:59:01PM -0800, Jakub Kicinski wrote: > On Wed, 12 Feb 2025 17:46:54 +0100 Alexander Lobakin wrote: > > > [PATCH next] ice: Fix signedness bug in ice_init_interrupt_scheme() > > > > I believe it should be "PATCH net" with > > > > > If pci_alloc_irq_vectors() can't allocate the minimum number of vectors > > > then it returns -ENOSPC so there is no need to check for that in the > > > caller. In fact, because pf->msix.min is an unsigned int, it means that > > > any negative error codes are type promoted to high positive values and > > > treated as success. So here the "return -ENOMEM;" is unreachable code. > > > Check for negatives instead. > > > > > > Fixes: 79d97b8cf9a8 ("ice: remove splitting MSI-X between features") > > > > a 'Stable:' tag here. > > Bug only exists in net-next if it comes from commit under Fixes. > So I think the patch is good as is. I want to resen this. My scripts should have put a net-next in the subject and I think that changing: - return -ENOMEM; + return vectors; actually does fall within the scope of the patch so I want to change that as well. There is no point in really breaking that into a separate patch from a practical perspective. regards, dan carpenter