From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: iproute2 won't compile without AF_VSOCK Date: Tue, 19 Jun 2018 14:29:22 -0600 Message-ID: References: <20180619084732.0de6d75d@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: netdev To: Stephen Hemminger , Steve Wise Return-path: Received: from mail-pg0-f47.google.com ([74.125.83.47]:38354 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755265AbeFSU3Z (ORCPT ); Tue, 19 Jun 2018 16:29:25 -0400 Received: by mail-pg0-f47.google.com with SMTP id c9-v6so384329pgf.5 for ; Tue, 19 Jun 2018 13:29:25 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 6/19/18 2:27 PM, David Ahern wrote: > On 6/19/18 9:47 AM, Stephen Hemminger wrote: >> On Tue, 19 Jun 2018 10:17:45 -0500 >> Steve Wise wrote: >> >>> Hey David, >>> >>> I'm trying to compile the latest iproute2 on an RHEL-7.3 distro, and it >>> fails to compile because AF_VSOCK is not defined.  Should this >>> functionality be a configure option to disable it on older distros? >>> >>> >>> Thanks, >>> >>> Steve. >>> >>> ---- >>> >>> misc >>>     CC       ss.o >>> ss.c:301:27: error: ‘AF_VSOCK’ undeclared here (not in a function) >>>    .families = FAMILY_MASK(AF_VSOCK), >>>                            ^ >>> ss.c:252:46: note: in definition of macro ‘FAMILY_MASK’ >>>  #define FAMILY_MASK(family) ((uint64_t)1 << (family)) >>>                                               ^ >>> ss.c:334:2: error: array index in initializer not of integer type >>>   [AF_VSOCK] = { >>>   ^ >>> ss.c:334:2: error: (near initialization for ‘default_afs’) >>> make[1]: *** [ss.o] Error 1 >>> make: *** [all] Error 2 >>> >> >> Probably should just add an #ifdef to takeout that if not present >> > > Most userspace tools have a compat header for cases like this. > > #ifndef AF_VSOCK > #define AF_VSOCK 40 > #endif > Add the above to include//utils.h; AF_MPLS is already there.