From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subash Abhinov Kasiviswanathan Subject: Re: [PATCH net-next 2/3] net: qualcomm: rmnet: Add support for ethtool private stats Date: Tue, 15 May 2018 12:09:11 -0600 Message-ID: References: <1526328527-20026-3-git-send-email-subashab@codeaurora.org> <201805151651.Vgq47bPJ%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Cc: kbuild-all@01.org, davem@davemloft.net, netdev@vger.kernel.org To: kbuild test robot Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:54566 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752483AbeEOSJM (ORCPT ); Tue, 15 May 2018 14:09:12 -0400 In-Reply-To: <201805151651.Vgq47bPJ%fengguang.wu@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On 2018-05-15 02:41, kbuild test robot wrote: > Hi Subash, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Subash-Abhinov-Kasiviswanathan/net-qualcomm-rmnet-Updates-2018-05-14/20180515-115355 > reproduce: > # apt-get install sparse > make ARCH=x86_64 allmodconfig > make C=1 CF=-D__CHECK_ENDIAN__ > > > sparse warnings: (new ones prefixed by >>) > >>> drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c:199:26: sparse: >>> symbol 'rmnet_ethtool_ops' was not declared. Should it be static? > > Please review and possibly fold the followup patch. > > --- > 0-DAY kernel test infrastructure Open Source Technology > Center > https://lists.01.org/pipermail/kbuild-all Intel > Corporation Thanks Fengguang. I will fix both issues in v2 -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project