From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f66.google.com ([209.85.160.66]:43129 "EHLO
        mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933386AbeCGQrV (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 7 Mar 2018 11:47:21 -0500
Received: by mail-pl0-f66.google.com with SMTP id f23-v6so1627938plr.10
        for <netdev@vger.kernel.org>; Wed, 07 Mar 2018 08:47:20 -0800 (PST)
Subject: Re: [PATCH iproute2-next 2/3] ipmroute: don't complain about unicast
 routes
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, Stephen Hemminger <sthemmin@microsoft.com>
References: <20180307010355.5011-1-stephen@networkplumber.org>
 <20180307010355.5011-3-stephen@networkplumber.org>
 <20180307080351.11d8bfa9@xeon-e3>
From: David Ahern <dsahern@gmail.com>
Message-ID: <d72d5f82-e4f9-f4bf-a596-529db69effc8@gmail.com>
Date: Wed, 7 Mar 2018 09:47:37 -0700
MIME-Version: 1.0
In-Reply-To: <20180307080351.11d8bfa9@xeon-e3>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 3/7/18 9:03 AM, Stephen Hemminger wrote:
> On Tue,  6 Mar 2018 17:03:54 -0800
> Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
>> From: Stephen Hemminger <sthemmin@microsoft.com>
>>
>> Every non-multicast route prints an error message.
>> Kernel doesn't filter out unicast routes, it is up to filter function
>> to do this.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> ---
>>  ip/ipmroute.c | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/ip/ipmroute.c b/ip/ipmroute.c
>> index aa5029b44f41..03ca0575e571 100644
>> --- a/ip/ipmroute.c
>> +++ b/ip/ipmroute.c
>> @@ -75,15 +75,14 @@ int print_mroute(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
>>  		fprintf(stderr, "BUG: wrong nlmsg len %d\n", len);
>>  		return -1;
>>  	}
>> -	if (r->rtm_type != RTN_MULTICAST) {
>> -		fprintf(stderr, "Not a multicast route (type: %s)\n",
>> -			rtnl_rtntype_n2a(r->rtm_type, b1, sizeof(b1)));
>> +
>> +	if (r->rtm_type != RTN_MULTICAST)
>>  		return 0;
>> -	}
>>  
>>  	parse_rtattr(tb, RTA_MAX, RTM_RTA(r), len);
>>  	table = rtm_get_table(r, tb);
>>  
>> +
>>  	if (filter.tb > 0 && filter.tb != table)
>>  		return 0;
>>  
> 
> Actually, this is a recent kernel regression. Should be fixed there
> 

from Yuval's recent multicast convergence changes?