From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [RFC PATCH net-next 03/19] ipv6: Clear nexthop flags upon netdev up Date: Wed, 3 Jan 2018 16:08:38 -0700 Message-ID: References: <20171231161513.25785-1-idosch@mellanox.com> <20171231161513.25785-4-idosch@mellanox.com> <20180103074418.GA761@splinter> <20180103164331.GA4926@splinter> <2a815a43-a9e9-10bd-7b4b-a3996b6952d2@gmail.com> <20180103174025.GA6584@splinter> <20180103205321.GA13248@splinter> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Ido Schimmel , netdev@vger.kernel.org, davem@davemloft.net, roopa@cumulusnetworks.com, nicolas.dichtel@6wind.com, mlxsw@mellanox.com To: Ido Schimmel Return-path: Received: from mail-pf0-f181.google.com ([209.85.192.181]:45950 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbeACXIk (ORCPT ); Wed, 3 Jan 2018 18:08:40 -0500 Received: by mail-pf0-f181.google.com with SMTP id u19so1349848pfa.12 for ; Wed, 03 Jan 2018 15:08:40 -0800 (PST) In-Reply-To: <20180103205321.GA13248@splinter> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/3/18 1:53 PM, Ido Schimmel wrote: > On Wed, Jan 03, 2018 at 11:47:16AM -0700, David Ahern wrote: >> On 1/3/18 10:40 AM, Ido Schimmel wrote: >>> David, can we please get back to the issue at hand? What's the problem >>> with the location of the call to rt6_sync_up()? >> >> My original comment was asking why do it on NETDEV_CHANGE when it should >> only be needed on NETDEV_UP. > > I can condition the call to rt6_sync_up() on the event being NETDEV_UP, > but the location needs to stay the same. Before that the interface still > doesn't have an IP address. it's fine as is. The NETDEV_CHANGE section has a break after calling rt6_sync_up(RTNH_F_LINKDOWN) which is added later. To your point, addrconf_dev_config will add a linklocal address.