From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH iproute2-next] tc: fq: support ce_threshold attribute
Date: Sat, 24 Nov 2018 08:38:50 -0700
Message-ID: <d74e16dd-1c40-dd6d-4e47-69ae45cc32b9@gmail.com>
References: <20181124063724.169456-1-edumazet@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev <netdev@vger.kernel.org>,
        Eric Dumazet <eric.dumazet@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f194.google.com ([209.85.215.194]:38252 "EHLO
        mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726012AbeKYC1e (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 24 Nov 2018 21:27:34 -0500
Received: by mail-pg1-f194.google.com with SMTP id g189so4230270pgc.5
        for <netdev@vger.kernel.org>; Sat, 24 Nov 2018 07:38:53 -0800 (PST)
In-Reply-To: <20181124063724.169456-1-edumazet@google.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 11/23/18 11:37 PM, Eric Dumazet wrote:
> Kernel commit 48872c11b772 ("net_sched: sch_fq: add dctcp-like marking")
> added support for TCA_FQ_CE_THRESHOLD attribute.
> 
> This patch adds iproute2 support for it.
> 
> It also makes sure fq_print_xstats() can deal with smaller tc_fq_qd_stats
> structures given by older kernels.
> 
> Usage :
> 
> FQATTRS="ce_threshold 4ms"
> TXQS=8
> 
> for ETH in eth0
> do
>  tc qd del dev $ETH root 2>/dev/null
>  tc qd add dev $ETH root handle 1: mq
>  for i in `seq 1 $TXQS`
>  do
>   tc qd add dev $ETH parent 1:$i fq $FQATTRS
>  done
> done
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
>  tc/q_fq.c | 32 ++++++++++++++++++++++++++++----
>  1 file changed, 28 insertions(+), 4 deletions(-)
> 


applied to iproute2-next. Thanks

Eric: the fq man page is out of date. Can you update it as well - not
just this argument but other missing ones? Thanks