From: Jamal Hadi Salim <jhs@mojatatu.com>
To: yotam gigi <yotam.gi@gmail.com>, Alexander Aring <aring@mojatatu.com>
Cc: davem@davemloft.net, "Cong Wang" <xiyou.wangcong@gmail.com>,
"Jiří Pírko" <jiri@resnulli.us>,
"Yuval Mintz" <yuvalm@mellanox.com>,
netdev@vger.kernel.org, kernel@mojatatu.com
Subject: Re: [PATCH net 3/3] net: sched: ife: check on metadata length
Date: Thu, 19 Apr 2018 08:10:14 -0400 [thread overview]
Message-ID: <d759ef63-aa5e-58ba-c140-debc20e21064@mojatatu.com> (raw)
In-Reply-To: <CANnrxJhUdk6s9_oRRyV+iC7Q_NzAFk5b9=FW5oGtuOuiFdHFvg@mail.gmail.com>
On 19/04/18 01:37 AM, yotam gigi wrote:
> On Thu, Apr 19, 2018 at 12:35 AM, Alexander Aring <aring@mojatatu.com> wrote:
>> This patch checks if sk buffer is available to dererence ife header. If
>> not then NULL will returned to signal an malformed ife packet. This
>> avoids to crashing the kernel from outside.
>>
>> Signed-off-by: Alexander Aring <aring@mojatatu.com>
>
> Reviewed-by: Yotam Gigi <yotam.gi@gmail.com>
>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
cheers,
jamal
prev parent reply other threads:[~2018-04-19 12:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 21:35 [PATCH net 0/3] net: sched: ife: malformed ife packet fixes Alexander Aring
2018-04-18 21:35 ` [PATCH net 1/3] net: sched: ife: signal not finding metaid Alexander Aring
2018-04-19 5:37 ` yotam gigi
2018-04-19 12:08 ` Jamal Hadi Salim
2018-04-18 21:35 ` [PATCH net 2/3] net: sched: ife: handle malformed tlv length Alexander Aring
2018-04-19 5:37 ` yotam gigi
2018-04-19 12:09 ` Jamal Hadi Salim
2018-04-19 19:30 ` David Miller
2018-04-18 21:35 ` [PATCH net 3/3] net: sched: ife: check on metadata length Alexander Aring
2018-04-19 5:37 ` yotam gigi
2018-04-19 12:10 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d759ef63-aa5e-58ba-c140-debc20e21064@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=aring@mojatatu.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
--cc=yotam.gi@gmail.com \
--cc=yuvalm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox