From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCHv3 net-next 2/2] selftests: add a selftest for directed
 broadcast forwarding
Date: Tue, 24 Jul 2018 12:36:07 -0600
Message-ID: <d76a2b15-8bc8-c745-ad27-840a8b57a1c3@gmail.com>
References: <cover.1532346504.git.lucien.xin@gmail.com>
 <8b30fcb80234d6d0f96e703487cf4a4195fc1c48.1532346504.git.lucien.xin@gmail.com>
 <a3c46ade85539e450f037e62984f750c7d56084d.1532346504.git.lucien.xin@gmail.com>
 <5af03df3-cad5-161e-31a8-3921fd64b98a@gmail.com>
 <CADvbK_dhnyZwqzff64ZQBggL8LcY__ot_h3Cj7Y-SOx1FxGbCw@mail.gmail.com>
 <ae804f04-2be2-e79d-5f43-033e275fbd66@gmail.com>
 <CADvbK_eje4O7ykBzZGQ_Yrg1Y-kaFfH58GcbAtBkGDqwft9GxQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: network dev <netdev@vger.kernel.org>, davem <davem@davemloft.net>,
        Davide Caratti <dcaratti@redhat.com>,
        Ido Schimmel <idosch@idosch.org>
To: Xin Long <lucien.xin@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f42.google.com ([209.85.160.42]:36769 "EHLO
        mail-pl0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2388366AbeGXTn4 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 24 Jul 2018 15:43:56 -0400
Received: by mail-pl0-f42.google.com with SMTP id e11-v6so2142274plb.3
        for <netdev@vger.kernel.org>; Tue, 24 Jul 2018 11:36:10 -0700 (PDT)
In-Reply-To: <CADvbK_eje4O7ykBzZGQ_Yrg1Y-kaFfH58GcbAtBkGDqwft9GxQ@mail.gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 7/24/18 11:55 AM, Xin Long wrote:
> INFO: bc_forwarding disabled on r1 =>
> INFO: h1 -> net2: reply from r1 (not forwarding)
> TEST: ping 198.51.100.255, expected reply from 192.0.2.1            [PASS]
> INFO: h1 -> net3: reply from r1 (not forwarding)
> TEST: ping 198.51.200.255, expected reply from 192.0.2.1            [PASS]
> INFO: h1 -> net1: reply from r1 (not dropping)
> TEST: ping 192.0.2.255, expected reply from 192.0.2.1               [PASS]
> ....
> how about this?

Personally, I think that is backwards. So like this:

INFO: bc_forwarding disabled on r1 =>
INFO: ping 198.51.100.255, expected reply from 192.0.2.1
TEST: h1 -> net2: reply from r1 (not forwarding)              [PASS]
INFO: ping 198.51.200.255, expected reply from 192.0.2.1
TEST: h1 -> net3: reply from r1 (not forwarding)              [PASS]
INFO: ping 192.0.2.255, expected reply from 192.0.2.1
TEST: h1 -> net1: reply from r1 (not dropping)                [PASS]
...