From: David Ahern <dsahern@gmail.com>
To: Petr Machata <petrm@nvidia.com>, netdev@vger.kernel.org
Cc: Ido Schimmel <idosch@nvidia.com>,
David Ahern <dsahern@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next 01/14] nexthop: Pass nh_config to replace_nexthop()
Date: Thu, 11 Mar 2021 08:20:19 -0700 [thread overview]
Message-ID: <d7712489-cd96-0bca-de2d-d75dd2bf1671@gmail.com> (raw)
In-Reply-To: <0a2e419897d7081c273762b58433c8c359ccd98a.1615387786.git.petrm@nvidia.com>
On 3/10/21 8:02 AM, Petr Machata wrote:
> Currently, replace assumes that the new group that is given is a
> fully-formed object. But mpath groups really only have one attribute, and
> that is the constituent next hop configuration. This may not be universally
> true. From the usability perspective, it is desirable to allow the replace
> operation to adjust just the constituent next hop configuration and leave
> the group attributes as such intact.
>
> But the object that keeps track of whether an attribute was or was not
> given is the nh_config object, not the next hop or next-hop group. To allow
> (selective) attribute updates during NH group replacement, propagate `cfg'
> to replace_nexthop() and further to replace_nexthop_grp().
>
> Signed-off-by: Petr Machata <petrm@nvidia.com>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> ---
> net/ipv4/nexthop.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2021-03-11 15:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 15:02 [PATCH net-next 00/14] nexthop: Resilient next-hop groups Petr Machata
2021-03-10 15:02 ` [PATCH net-next 01/14] nexthop: Pass nh_config to replace_nexthop() Petr Machata
2021-03-11 15:20 ` David Ahern [this message]
2021-03-10 15:02 ` [PATCH net-next 02/14] nexthop: __nh_notifier_single_info_init(): Make nh_info an argument Petr Machata
2021-03-11 15:21 ` David Ahern
2021-03-10 15:02 ` [PATCH net-next 03/14] nexthop: Add a dedicated flag for multipath next-hop groups Petr Machata
2021-03-11 15:28 ` David Ahern
2021-03-11 15:39 ` Petr Machata
2021-03-11 15:53 ` David Ahern
2021-03-11 16:57 ` Petr Machata
2021-03-10 15:02 ` [PATCH net-next 04/14] nexthop: Add netlink defines and enumerators for resilient NH groups Petr Machata
2021-03-11 15:34 ` David Ahern
2021-03-11 15:45 ` Petr Machata
2021-03-11 15:49 ` David Ahern
2021-03-11 16:00 ` Petr Machata
2021-03-10 15:02 ` [PATCH net-next 05/14] nexthop: Add implementation of resilient next-hop groups Petr Machata
2021-03-11 15:47 ` David Ahern
2021-03-10 15:02 ` [PATCH net-next 06/14] nexthop: Add data structures for resilient group notifications Petr Machata
2021-03-11 15:55 ` David Ahern
2021-03-10 15:02 ` [PATCH net-next 07/14] nexthop: Implement notifiers for resilient nexthop groups Petr Machata
2021-03-11 15:57 ` David Ahern
2021-03-10 15:02 ` [PATCH net-next 08/14] nexthop: Allow setting "offload" and "trap" indication of nexthop buckets Petr Machata
2021-03-11 16:03 ` David Ahern
2021-03-10 15:03 ` [PATCH net-next 09/14] nexthop: Allow reporting activity " Petr Machata
2021-03-11 16:04 ` David Ahern
2021-03-10 15:03 ` [PATCH net-next 10/14] nexthop: Add netlink handlers for resilient nexthop groups Petr Machata
2021-03-11 16:11 ` David Ahern
2021-03-10 15:03 ` [PATCH net-next 11/14] nexthop: Add netlink handlers for bucket dump Petr Machata
2021-03-11 16:17 ` David Ahern
2021-03-10 15:03 ` [PATCH net-next 12/14] nexthop: Add netlink handlers for bucket get Petr Machata
2021-03-11 16:19 ` David Ahern
2021-03-10 15:03 ` [PATCH net-next 13/14] nexthop: Notify userspace about bucket migrations Petr Machata
2021-03-11 16:20 ` David Ahern
2021-03-10 15:03 ` [PATCH net-next 14/14] nexthop: Enable resilient next-hop groups Petr Machata
2021-03-11 16:20 ` David Ahern
2021-03-11 16:22 ` [PATCH net-next 00/14] nexthop: Resilient " David Ahern
2021-03-11 17:18 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7712489-cd96-0bca-de2d-d75dd2bf1671@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).