From: David Ahern <dsahern@gmail.com>
To: Joe Perches <joe@perches.com>, David Miller <davem@davemloft.net>,
cugyly@163.com
Cc: netdev@vger.kernel.org, Linyu.Yuan@alcatel-sbell.com.cn
Subject: Re: [PATCH net-next] net: ndisc.c: reduce size of __ndisc_fill_addr_option()
Date: Mon, 29 May 2017 21:42:16 -0600 [thread overview]
Message-ID: <d774d7d7-5eb2-f107-b939-fbd3a8ac97a7@gmail.com> (raw)
In-Reply-To: <1496115666.2618.9.camel@perches.com>
On 5/29/17 9:41 PM, Joe Perches wrote:
> On Mon, 2017-05-29 at 23:30 -0400, David Miller wrote:
>> From: yuan linyu <cugyly@163.com>
>> Date: Sat, 27 May 2017 06:00:52 +0800
>>
>>> From: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
>>>
>>> Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
>> Applied, thanks.
> OK, but is it really safe though?
>
> Could "space" (an int) ever be negative after
> subtracting "pad" and "data_len"?
>
that function should be converted to skb_put_zero once it hits net-next.
next prev parent reply other threads:[~2017-05-30 3:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 22:00 [PATCH net-next] net: ndisc.c: reduce size of __ndisc_fill_addr_option() yuan linyu
2017-05-30 3:30 ` David Miller
2017-05-30 3:41 ` Joe Perches
2017-05-30 3:42 ` David Ahern [this message]
2017-05-31 0:07 ` YUAN Linyu
2017-05-31 0:29 ` YUAN Linyu
2017-05-31 0:39 ` David Ahern
2017-05-31 1:00 ` YUAN Linyu
2017-05-31 0:06 ` YUAN Linyu
-- strict thread matches above, loose matches on Subject: below --
2017-05-27 15:15 Alexey Dobriyan
2017-05-30 3:31 ` David Miller
2017-05-30 4:24 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d774d7d7-5eb2-f107-b939-fbd3a8ac97a7@gmail.com \
--to=dsahern@gmail.com \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=cugyly@163.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).