From: Saeed Mahameed <saeedm@mellanox.com>
To: "davem@davemloft.net" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Or Gerlitz <ogerlitz@mellanox.com>
Subject: Re: mlx5 stable backport help
Date: Thu, 21 Feb 2019 00:43:13 +0000 [thread overview]
Message-ID: <d7aa52a751ed2e2a77fa05df23ecad4444f66387.camel@mellanox.com> (raw)
In-Reply-To: <20190220.162127.148580465432446977.davem@davemloft.net>
On Wed, 2019-02-20 at 16:21 -0800, David Miller wrote:
> From: Saeed Mahameed <saeedm@mellanox.com>
> Date: Wed, 20 Feb 2019 23:58:12 +0000
>
> > Maybe you have some git config which fails on the warning i saw..
>
> Put the actual commit into a patch using "git format-patch" then try
> to use "git am" to apply it.
>
> I'm not doing anything fancy.
I see, for some reason cherry-pick is happy to resolve the conflict
without human help.
Anyway the conflict is really simple and contextual, 2 hunks will fail
1) adding a new filed "max_mod_hdr_actions" to "struct
mlx5e_tc_flow_parse_attr"
2) at parse_tc_pedit_action() line 1924 :
replace:
- err = alloc_mod_hdr_actions(priv, a, namespace, parse_attr);
- if (err)
- goto out_err;
with:
+ if (!parse_attr->mod_hdr_actions) {
+ err = alloc_mod_hdr_actions(priv, a, namespace,
parse_attr);
+ if (err)
+ goto out_err;
+ }
all in drivers/net/ethernet/mellanox/mlx5/core/en_tc.c file
they fail since the surrounding code is slightly different.
next prev parent reply other threads:[~2019-02-21 0:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 6:36 mlx5 stable backport help David Miller
2019-02-20 20:01 ` Saeed Mahameed
2019-02-20 20:27 ` David Miller
2019-02-20 23:58 ` Saeed Mahameed
2019-02-21 0:21 ` David Miller
2019-02-21 0:43 ` Saeed Mahameed [this message]
2019-02-21 10:21 ` Or Gerlitz
2019-02-21 22:35 ` Saeed Mahameed
2019-02-22 9:13 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7aa52a751ed2e2a77fa05df23ecad4444f66387.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox