* ip6_forward / NF_HOOK and counters
@ 2018-03-27 1:35 Jeff Barnhill
2018-03-30 15:06 ` David Ahern
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Barnhill @ 2018-03-27 1:35 UTC (permalink / raw)
To: netdev
At the end of ip6_forward(), is there a good reason why
IPSTATS_MIB_OUTFORWDATAGRAMS and IPSTATS_MIB_OUTOCTETS are incremented
before the NF_HOOK? If the hook steals or drops the packet, this
counts still go up, which seems incorrect.
v4/ip_forward() increments these counters in ip_forward_finish(). It
seems that v6 should do it in ip6_forward_finish() ?? Thoughts?
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ip6_forward / NF_HOOK and counters
2018-03-27 1:35 ip6_forward / NF_HOOK and counters Jeff Barnhill
@ 2018-03-30 15:06 ` David Ahern
0 siblings, 0 replies; 2+ messages in thread
From: David Ahern @ 2018-03-30 15:06 UTC (permalink / raw)
To: Jeff Barnhill, netdev
On 3/26/18 7:35 PM, Jeff Barnhill wrote:
> At the end of ip6_forward(), is there a good reason why
> IPSTATS_MIB_OUTFORWDATAGRAMS and IPSTATS_MIB_OUTOCTETS are incremented
> before the NF_HOOK? If the hook steals or drops the packet, this
> counts still go up, which seems incorrect.
>
> v4/ip_forward() increments these counters in ip_forward_finish(). It
> seems that v6 should do it in ip6_forward_finish() ?? Thoughts?
>
> Jeff
>
I agree and think it is part of the alignment between IPv4 and IPv6.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-30 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-27 1:35 ip6_forward / NF_HOOK and counters Jeff Barnhill
2018-03-30 15:06 ` David Ahern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).