From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: Re: [PATCH net] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT Date: Wed, 7 Feb 2018 20:26:33 +0100 Message-ID: References: <80518b40-3467-6e1b-7ee8-6e860afde049@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" To: Florian Fainelli , Andrew Lunn , David Miller Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:38349 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754467AbeBGT0k (ORCPT ); Wed, 7 Feb 2018 14:26:40 -0500 Received: by mail-wm0-f65.google.com with SMTP id 141so5450501wme.3 for ; Wed, 07 Feb 2018 11:26:40 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Am 07.02.2018 um 20:06 schrieb Florian Fainelli: > > > On 02/07/2018 10:44 AM, Heiner Kallweit wrote: >> This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added >> long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt indicates >> also PHY state changes and we should do what the symbol says. > > Do you use phy_enable_interrupts() to configure how the PHY interrupts > will be flowing through the Ethernet MAC? > No. And I'm not sure I understand your question correctly. The change applies the same behavior as e.g. in phy_connect_direct() where phy_start_interrupts() is called only if phy_dev->irq > 0. >> >> Signed-off-by: Heiner Kallweit >> --- >> drivers/net/phy/phy.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c >> index f3313a129..50ed35a45 100644 >> --- a/drivers/net/phy/phy.c >> +++ b/drivers/net/phy/phy.c >> @@ -822,7 +822,7 @@ void phy_start(struct phy_device *phydev) >> phy_resume(phydev); >> >> /* make sure interrupts are re-enabled for the PHY */ >> - if (phydev->irq != PHY_POLL) { >> + if (phydev->irq > 0) { >> err = phy_enable_interrupts(phydev); >> if (err < 0) >> break; >> >