From: Matthieu Baerts <matttbe@kernel.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Quentin Deslandes <qde@naccy.de>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] Revert "ss: prevent "Process" column from being printed unless requested"
Date: Mon, 15 Jan 2024 20:14:46 +0100 [thread overview]
Message-ID: <d7cb3833-7159-4451-96da-275ada06a2cc@kernel.org> (raw)
In-Reply-To: <20240115090548.04eb7f6f@hermes.local>
On 15/01/2024 18:05, Stephen Hemminger wrote:
> On Mon, 15 Jan 2024 12:27:23 +0100
> Matthieu Baerts <matttbe@kernel.org> wrote:
>
>> Hi Stephen,
>>
>> On 13/01/2024 17:54, Stephen Hemminger wrote:
>>> This reverts commit 1607bf531fd2f984438d227ea97312df80e7cf56.
>>>
>>> This commit is being reverted because it breaks output of tcp info.
>>
>> Thank you for having reverted this commit to solve the issue.
>>
>> It looks like it breaks more than just TCP info output, please see [1].
>> Because of the impact this issue seems to have, do you think it could be
>> possible to have a v6.7.1 version including this revert patch or the fix
>> from [1]?
>
>
> Sorry, no this is not a big enough issue for a release.
OK, understood.
That's quite a bit of work for us for the MPTCP kselftests to support
this v6.7 version (25 places to patch, split in 10+ commits for the
backports, etc.). We will then add a comment somewhere to say that this
version of 'ss' has an issue and is incompatible with our selftests.
Hopefully this version will not be used by the other CIs we don't control.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2024-01-15 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 16:54 [PATCH iproute2] Revert "ss: prevent "Process" column from being printed unless requested" Stephen Hemminger
2024-01-14 19:00 ` patchwork-bot+netdevbpf
2024-01-15 11:27 ` Matthieu Baerts
2024-01-15 17:05 ` Stephen Hemminger
2024-01-15 19:14 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7cb3833-7159-4451-96da-275ada06a2cc@kernel.org \
--to=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qde@naccy.de \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).