From: Vladimir Zapolskiy <vz@mleia.com>
To: zhong jiang <zhongjiang@huawei.com>, davem@davemloft.net
Cc: fugang.duan@nxp.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: remove redundant null pointer check before of_node_put
Date: Mon, 17 Sep 2018 00:11:09 +0300 [thread overview]
Message-ID: <d7d33c5e-f4b6-cfaa-cca7-c4ffe521bae4@mleia.com> (raw)
In-Reply-To: <1537103622-63482-1-git-send-email-zhongjiang@huawei.com>
On 09/16/2018 04:13 PM, zhong jiang wrote:
> of_node_put has taken the null pinter check into account. So it is
> safe to remove the duplicated check before of_node_put.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
typo in the commit message, s/pinter/pointer/
Other than that please feel free to add my
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
next prev parent reply other threads:[~2018-09-17 2:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-16 13:13 [PATCH] net: ethernet: remove redundant null pointer check before of_node_put zhong jiang
2018-09-16 21:11 ` Vladimir Zapolskiy [this message]
2018-09-17 1:55 ` Andy Duan
2018-09-17 15:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7d33c5e-f4b6-cfaa-cca7-c4ffe521bae4@mleia.com \
--to=vz@mleia.com \
--cc=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).