From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Zapolskiy Subject: Re: [PATCH] net: ethernet: remove redundant null pointer check before of_node_put Date: Mon, 17 Sep 2018 00:11:09 +0300 Message-ID: References: <1537103622-63482-1-git-send-email-zhongjiang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: fugang.duan@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: zhong jiang , davem@davemloft.net Return-path: Received: from mleia.com ([178.79.152.223]:43670 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728168AbeIQCfc (ORCPT ); Sun, 16 Sep 2018 22:35:32 -0400 In-Reply-To: <1537103622-63482-1-git-send-email-zhongjiang@huawei.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 09/16/2018 04:13 PM, zhong jiang wrote: > of_node_put has taken the null pinter check into account. So it is > safe to remove the duplicated check before of_node_put. > > Signed-off-by: zhong jiang typo in the commit message, s/pinter/pointer/ Other than that please feel free to add my Reviewed-by: Vladimir Zapolskiy