From mboxrd@z Thu Jan  1 00:00:00 1970
From: Toshiaki Makita <toshiaki.makita1@gmail.com>
Subject: Re: [PATCH v7 bpf-next 05/10] veth: Handle xdp_frames in xdp napi
 ring
Date: Thu, 2 Aug 2018 23:10:38 +0900
Message-ID: <d7ef0a42-1ea0-587e-3dfc-20558ba0a428@gmail.com>
References: <1533207314-2572-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>
 <1533207314-2572-6-git-send-email-makita.toshiaki@lab.ntt.co.jp>
 <20180802134548.2230455b@redhat.com>
 <4402804f-bf7b-9ca0-baa9-1415884b0a80@gmail.com>
 <20180802155336.15169974@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>, netdev@vger.kernel.org,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        John Fastabend <john.fastabend@gmail.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf1-f194.google.com ([209.85.210.194]:46391 "EHLO
        mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1732231AbeHBQCD (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 2 Aug 2018 12:02:03 -0400
Received: by mail-pf1-f194.google.com with SMTP id u24-v6so1376581pfn.13
        for <netdev@vger.kernel.org>; Thu, 02 Aug 2018 07:10:40 -0700 (PDT)
In-Reply-To: <20180802155336.15169974@redhat.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 18/08/02 (木) 22:53, Jesper Dangaard Brouer wrote:
> On Thu, 2 Aug 2018 22:17:53 +0900
> Toshiaki Makita <toshiaki.makita1@gmail.com> wrote:
> 
>> On 18/08/02 (木) 20:45, Jesper Dangaard Brouer wrote:
>>> On Thu,  2 Aug 2018 19:55:09 +0900
>>> Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp> wrote:
>>>    
>>>> +	headroom = frame->data - delta - (void *)frame;
>>>
>>> Your calculation of headroom is still adding an assumption that
>>> xdp_frame is located in the top of data area, that is unnecessary.
>>>
>>> The headroom can be calculated as:
>>>
>>>    headroom = sizeof(struct xdp_frame) + frame->headroom - delta;
>>
>> Thanks. But I'm not sure I get what you are requesting.
> 
> I'm simply requesting you do not use the (void *)frame pointer address,
> to calculate the headroom, as it can be calculated in another way.

I don't see difference, but ok I can change this calculation as you 
prefer a different way.

>> Supposing xdp_frame is not located in the top of data area, what ensures
>> that additional sizeof(struct xdp_frame) can be used?
> 
> The calculation in convert_to_xdp_frame() assures this.  If we later
> add an xdp_frame that is not located in the top of data area, and want
> to change the reserved headroom size, then we deal with it, and update
> the code.

I just thought you are requesting the change so that we don't need to 
change this code even when convert_to_xdp_frame() is changed. Now I see 
my guess was wrong.

will send v8.

Thanks,
Toshiaki Makita