From: Daniel Borkmann <daniel@iogearbox.net>
To: Yonghong Song <yhs@fb.com>, Martin KaFai Lau <kafai@fb.com>,
netdev@vger.kernel.org
Cc: Alexei Starovoitov <ast@fb.com>, kernel-team@fb.com
Subject: Re: [PATCH bpf] bpf: btf: Ensure the member->offset is in the right order
Date: Tue, 24 Jul 2018 01:22:28 +0200 [thread overview]
Message-ID: <d7f2d88b-1416-a50f-8c1c-ed0ff44b4988@iogearbox.net> (raw)
In-Reply-To: <0e0a30fe-e1af-681c-2ccd-e9db91d5246f@fb.com>
On 07/23/2018 08:45 PM, Yonghong Song wrote:
> On 7/20/18 5:38 PM, Martin KaFai Lau wrote:
>> This patch ensures the member->offset of a struct
>> is in the correct order (i.e the later member's offset cannot
>> go backward).
>>
>> The current "pahole -J" BTF encoder does not generate something
>> like this. However, checking this can ensure future encoder
>> will not violate this.
>>
>> Fixes: 69b693f0aefa ("bpf: btf: Introduce BPF Type Format (BTF)")
>> Signed-off-by: Martin KaFai Lau <kafai@fb.com>
> Acked-by: Yonghong Song <yhs@fb.com>
Applied to bpf, thanks!
prev parent reply other threads:[~2018-07-24 0:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-21 0:38 [PATCH bpf] bpf: btf: Ensure the member->offset is in the right order Martin KaFai Lau
2018-07-23 18:45 ` Yonghong Song
2018-07-23 23:22 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7f2d88b-1416-a50f-8c1c-ed0ff44b4988@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@fb.com \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).