netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>, <mkubecek@suse.cz>
Cc: Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH ethtool-next v2] netlink: fec: add errors histogram statistics
Date: Wed, 15 Oct 2025 13:22:19 -0700	[thread overview]
Message-ID: <d7f85aa5-6edb-45b2-9c8d-04874b720f8b@intel.com> (raw)
In-Reply-To: <20251014212018.7933-1-vadim.fedorenko@linux.dev>


[-- Attachment #1.1: Type: text/plain, Size: 1480 bytes --]



On 10/14/2025 2:20 PM, Vadim Fedorenko wrote:
> Linux 6.18 has FEC errors histogram statistics API added. Add support
> for extra attributes in ethtool.
> 
>  # ethtool -I --show-fec eni8np1
> FEC parameters for eni8np1:
> Supported/Configured FEC encodings: None
> Active FEC encoding: None
> Statistics:
>   corrected_blocks: 123
>   uncorrectable_blocks: 4
>   fec_symbol_err_0: 445 [ per_lane:  125, 120, 100, 100 ]
>   fec_symbol_err_1_to_3: 12
>   fec_symbol_err_4_to_7: 2
> 
>  # ethtool -j -I --show-fec eni8np1
> [ {
>         "ifname": "eni8np1",
>         "config": [ "None" ],
>         "active": [ "None" ],
>         "statistics": {
>             "corrected_blocks": {
>                 "total": 123
>             },
>             "uncorrectable_blocks": {
>                 "total": 4
>             },
>             "hist": [ {
>                     "bin_low": 0,
>                     "bin_high": 0,
>                     "total": 445,
>                     "lanes": [ 125,120,100,100 ]
>                 },{
>                     "bin_low": 1,
>                     "bin_high": 3,
>                     "total": 12
>                 },{
>                     "bin_low": 4,
>                     "bin_high": 7,
>                     "total": 2
>                 } ]
>         }
>     } ]
> 
> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

      reply	other threads:[~2025-10-15 20:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14 21:20 [PATCH ethtool-next v2] netlink: fec: add errors histogram statistics Vadim Fedorenko
2025-10-15 20:22 ` Jacob Keller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7f85aa5-6edb-45b2-9c8d-04874b720f8b@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).