From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9644A25B1CB; Wed, 18 Feb 2026 09:35:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771407351; cv=none; b=O06bxt+hanGkfHXUdMchyEGXO+iCVnRb2fpe7mDRklViM1yDSqXo3rTj/iypBFM79u+p08npOZL4umV6RgD8UwNArJt23aLmlYHt63pfPSNi6m9Js5uOhKTTMmQIkxeVAINmhA/gY7DdA9hxBc+eOIZjOCL6/v6nRYKNov3DMDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771407351; c=relaxed/simple; bh=UC89tnAJ/TaJfObea4vuqfLAsYoUeHdpLM/Ry6iKVPY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a5+on4kBylfZ2iiZJjeNiN6iFZNsFLJKBnfGc2YXQeVLrDY3lqeBJvbwihuESSP7JAmB3CDOXazj+IHHJaktupXn7aqciqSdFVlMMT1aeWumXEnbfauB+cH0OPCMRSD4LgpVJxXf7WS03mPgX8jn19SPRQ4VNcDvoX3evAs/xEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=A1kuHgv/; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="A1kuHgv/" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id D06CB4E40F41; Wed, 18 Feb 2026 09:35:46 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 93E0160738; Wed, 18 Feb 2026 09:35:46 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C542B103688BE; Wed, 18 Feb 2026 10:35:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1771407345; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=/1pklFYcQL1hVqt59Ida+Q2VbdHjCuaFWFKrwPhmtMg=; b=A1kuHgv/oLJe43UGhNiPEWwcT4+YFn2/0F2pBnb2u8Q9tL5yIJa82nQj7GtsDToPFozDX4 hCjozvQ8s41PuUIy1YKFtf13uNhHYAr07J7F/xcFNsxivrjNnM7KqmRKeYx/t7iBFA9Xre vuaQUNGZfePJBgzPAYW30ls8LCK8KVdMUO7/0OUh/k+ILK+zp0jICNc+TO359xaXrErxkP vm9h6cFhHo2C2atJwOqSXLhyL8sClrx9yg+yUTwV9Q7HqbcjpWUsKOcIJmdcFDMiopI+Ko nmJhhlgHf1pZO/UpkXECwK+fUIkPa206Iq1BetNRaQOJ2voAXn99o8QpiHoVjg== Message-ID: Date: Wed, 18 Feb 2026 10:35:41 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 5/8] net: dsa: microchip: Add KSZ8463 tail tag handling To: Jakub Kicinski Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Simon Horman , Pascal Eberhard , =?UTF-8?Q?Miqu=C3=A8l_Raynal?= , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260127-ksz8463-ptp-v4-0-652e021aae86@bootlin.com> <20260127-ksz8463-ptp-v4-5-652e021aae86@bootlin.com> <20260129201535.317d90bd@kernel.org> From: Bastien Curutchet Content-Language: en-US In-Reply-To: <20260129201535.317d90bd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Jakub, On 1/30/26 5:15 AM, Jakub Kicinski wrote: > Sorry for the nit but: > > On Tue, 27 Jan 2026 10:06:47 +0100 Bastien Curutchet (Schneider > Electric) wrote: >> case DSA_TAG_PROTO_KSZ9893: >> case DSA_TAG_PROTO_KSZ9477: >> + case DSA_TAG_PROTO_KSZ8463: >> case DSA_TAG_PROTO_LAN937X: > > This.. > >> #define KSZ9477_NAME "ksz9477" >> #define KSZ9893_NAME "ksz9893" >> #define LAN937X_NAME "lan937x" >> +#define KSZ8463_NAME "ksz8463" > > this > >> @@ -457,6 +526,7 @@ static struct dsa_tag_driver *dsa_tag_driver_array[] = { >> &DSA_TAG_DRIVER_NAME(ksz9477_netdev_ops), >> &DSA_TAG_DRIVER_NAME(ksz9893_netdev_ops), >> &DSA_TAG_DRIVER_NAME(lan937x_netdev_ops), >> + &DSA_TAG_DRIVER_NAME(ksz8463_netdev_ops), > > and this - appear to have been alphabetically sorted previously, now > we're just adding at the end. Good catch, I'll fix this in next iteration (once net-next re-opens). Best regards, Bastien