public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: b53: prevent standalone from trying to forward to other ports
Date: Thu, 26 Feb 2026 13:26:06 -0800	[thread overview]
Message-ID: <d7f9775e-0af6-4294-837b-47e31e0d30d7@broadcom.com> (raw)
In-Reply-To: <ce4d9b7b-aaf6-4796-94fb-8c3d6a1dcd4d@gmail.com>

On 2/26/26 12:24, Rafał Miłecki wrote:
> W dniu 8.05.2025 o 11:14, Jonas Gorski pisze:
>> When bridged ports and standalone ports share a VLAN, e.g. via VLAN
>> uppers, or untagged traffic with a vlan unaware bridge, the ASIC will
>> still try to forward traffic to known FDB entries on standalone ports.
>> But since the port VLAN masks prevent forwarding to bridged ports, this
>> traffic will be dropped.
>>
>> This e.g. can be observed in the bridge_vlan_unaware ping tests, where
>> this breaks pinging with learning on.
>>
>> Work around this by enabling the simplified EAP mode on switches
>> supporting it for standalone ports, which causes the ASIC to redirect
>> traffic of unknown source MAC addresses to the CPU port.
>>
>> Since standalone ports do not learn, there are no known source MAC
>> addresses, so effectively this redirects all incoming traffic to the CPU
>> port.
> 
> This change broke standalone ports (those not being part of bridge) on 
> Northstar (BCM5301X) devices. We got reports from users about WAN ports 
> on routers not working anymore:
> https://github.com/openwrt/openwrt/issues/21187
> https://github.com/openwrt/openwrt/issues/21349
> 
> Can you take another look at those changes, see if something me be 
> wrong / missing?

Checking the BCM5301X datasheet, the register definitions look correct.

The first report appears to be for a Netgear R7000 which AFAICT would 
utilize port 8 of the switch as the CPU port, which would be correct.

The other report is for a Netgear R6250 where port 5 would be acting as 
the CPU port, that could be an issue unless the switch is also 
programmed to use port 5 as the IMP port.

Could you try to program GMNGCFG (page 0x02, offset 0) bits 7:6 to have 
the value 0b11 which is dual IMP port (IMPO is port 8 and IMP1 is port 
5) and see if that helps?
-- 
Florian

  reply	other threads:[~2026-02-26 21:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-08  9:14 [PATCH net] net: dsa: b53: prevent standalone from trying to forward to other ports Jonas Gorski
2025-05-13 10:28 ` Paolo Abeni
2025-05-13 12:43 ` Florian Fainelli
2025-05-13 12:55 ` Vladimir Oltean
2025-05-13 13:50 ` patchwork-bot+netdevbpf
2026-02-26 20:24 ` Rafał Miłecki
2026-02-26 21:26   ` Florian Fainelli [this message]
2026-02-27 12:23     ` Rafał Miłecki
2026-02-27 13:32       ` Rafał Miłecki
2026-02-27 17:58         ` Florian Fainelli
2026-02-27 18:13           ` Rafał Miłecki
2026-02-28 13:30             ` Jonas Gorski
2026-03-02 12:34               ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7f9775e-0af6-4294-837b-47e31e0d30d7@broadcom.com \
    --to=florian.fainelli@broadcom.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=jonas.gorski@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox