From: Paolo Abeni <pabeni@redhat.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next 4/7] net: lan966x: Add support for offloading dscp table
Date: Tue, 16 May 2023 09:17:08 +0200 [thread overview]
Message-ID: <d84a75724637a58d25ecbc35316b6b11a979e923.camel@redhat.com> (raw)
In-Reply-To: <20230514201029.1867738-5-horatiu.vultur@microchip.com>
On Sun, 2023-05-14 at 22:10 +0200, Horatiu Vultur wrote:
> @@ -117,12 +164,16 @@ static int lan966x_dcb_ieee_setapp(struct net_device *dev, struct dcb_app *app)
> if (prio) {
> app_itr = *app;
> app_itr .priority = prio;
> - dcb_ieee_delapp(dev, &app_itr);
> + lan966x_dcb_ieee_delapp(dev, &app_itr);
> }
>
> - err = dcb_ieee_setapp(dev, app);
> + if (app->selector == IEEE_8021QAZ_APP_SEL_DSCP)
> + err = lan966x_dcb_ieee_dscp_setdel(dev, app, dcb_ieee_setapp);
> + else
> + err = dcb_ieee_setapp(dev, app);
> +
> if (err)
> - goto out;
> + return err;
As Piotr suggested, please drop the out: label altogether, replacing
even the other 'goto out;' statement with a plain return. Additionally
you can replace the final:
return err;
in this function with:
return 0;
Thanks,
Paolo
next prev parent reply other threads:[~2023-05-16 7:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-14 20:10 [PATCH net-next 0/7] net: lan966x: Add support for PCP, DEI, DSCP Horatiu Vultur
2023-05-14 20:10 ` [PATCH net-next 1/7] net: lan966x: Add registers to configure " Horatiu Vultur
2023-05-15 7:43 ` Piotr Raczynski
2023-05-14 20:10 ` [PATCH net-next 2/7] net: lan966x: Add support for offloading pcp table Horatiu Vultur
2023-05-15 10:16 ` Piotr Raczynski
2023-05-15 10:24 ` Piotr Raczynski
2023-05-16 7:07 ` Paolo Abeni
2023-05-14 20:10 ` [PATCH net-next 3/7] net: lan966x: Add support for apptrust Horatiu Vultur
2023-05-14 20:10 ` [PATCH net-next 4/7] net: lan966x: Add support for offloading dscp table Horatiu Vultur
2023-05-15 10:22 ` Piotr Raczynski
2023-05-16 7:17 ` Paolo Abeni [this message]
2023-05-14 20:10 ` [PATCH net-next 5/7] net: lan966x: Add support for offloading default prio Horatiu Vultur
2023-05-15 15:30 ` Piotr Raczynski
2023-05-14 20:10 ` [PATCH net-next 6/7] net: lan966x: Add support for PCP rewrite Horatiu Vultur
2023-05-14 20:10 ` [PATCH net-next 7/7] net: lan966x: Add support for DSCP rewrite Horatiu Vultur
2023-05-15 9:55 ` [PATCH net-next 0/7] net: lan966x: Add support for PCP, DEI, DSCP Daniel.Machon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d84a75724637a58d25ecbc35316b6b11a979e923.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).