* bpftool doc man page build failure
@ 2019-05-03 16:21 Yonghong Song
2019-05-03 16:54 ` Quentin Monnet
0 siblings, 1 reply; 3+ messages in thread
From: Yonghong Song @ 2019-05-03 16:21 UTC (permalink / raw)
To: netdev, bpf@vger.kernel.org, Quentin Monnet, Alexei Starovoitov,
Daniel Borkmann
Quentin,
I hit the following errors with latest bpf-next.
-bash-4.4$ make man
GEN bpftool-perf.8
GEN bpftool-map.8
GEN bpftool.8
GEN bpftool-net.8
GEN bpftool-feature.8
GEN bpftool-prog.8
GEN bpftool-cgroup.8
GEN bpftool-btf.8
GEN bpf-helpers.rst
Parsed description of 111 helper function(s)
Traceback (most recent call last):
File "../../../../scripts/bpf_helpers_doc.py", line 421, in <module>
printer.print_all()
File "../../../../scripts/bpf_helpers_doc.py", line 187, in print_all
self.print_one(helper)
File "../../../../scripts/bpf_helpers_doc.py", line 378, in print_one
self.print_proto(helper)
File "../../../../scripts/bpf_helpers_doc.py", line 356, in print_proto
proto = helper.proto_break_down()
File "../../../../scripts/bpf_helpers_doc.py", line 56, in
proto_break_down
'type' : capture.group(1),
AttributeError: 'NoneType' object has no attribute 'group'
make: *** [bpf-helpers.rst] Error 1
-bash-4.4$ pwd
/home/yhs/work/net-next/tools/bpf/bpftool/Documentation
-bash-4.4$
Maybe a format issue in the comments with some recent helpers?
Thanks,
Yonghong
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: bpftool doc man page build failure
2019-05-03 16:21 bpftool doc man page build failure Yonghong Song
@ 2019-05-03 16:54 ` Quentin Monnet
2019-05-03 16:56 ` Yonghong Song
0 siblings, 1 reply; 3+ messages in thread
From: Quentin Monnet @ 2019-05-03 16:54 UTC (permalink / raw)
To: Yonghong Song, netdev, bpf@vger.kernel.org, Alexei Starovoitov,
Daniel Borkmann
2019-05-03 16:21 UTC+0000 ~ Yonghong Song <yhs@fb.com>
> Quentin,
>
> I hit the following errors with latest bpf-next.
>
> -bash-4.4$ make man
> GEN bpftool-perf.8
> GEN bpftool-map.8
> GEN bpftool.8
> GEN bpftool-net.8
> GEN bpftool-feature.8
> GEN bpftool-prog.8
> GEN bpftool-cgroup.8
> GEN bpftool-btf.8
> GEN bpf-helpers.rst
> Parsed description of 111 helper function(s)
> Traceback (most recent call last):
> File "../../../../scripts/bpf_helpers_doc.py", line 421, in <module>
> printer.print_all()
> File "../../../../scripts/bpf_helpers_doc.py", line 187, in print_all
> self.print_one(helper)
> File "../../../../scripts/bpf_helpers_doc.py", line 378, in print_one
> self.print_proto(helper)
> File "../../../../scripts/bpf_helpers_doc.py", line 356, in print_proto
> proto = helper.proto_break_down()
> File "../../../../scripts/bpf_helpers_doc.py", line 56, in
> proto_break_down
> 'type' : capture.group(1),
> AttributeError: 'NoneType' object has no attribute 'group'
> make: *** [bpf-helpers.rst] Error 1
> -bash-4.4$ pwd
> /home/yhs/work/net-next/tools/bpf/bpftool/Documentation
> -bash-4.4$
>
> Maybe a format issue in the comments with some recent helpers?
>
> Thanks,
>
> Yonghong
>
Hi Yonghong,
Thanks for the notice! Yes, I observed the same thing not long ago. It
seems that the Python script breaks on the "unsigned long" pointer
argument for strtoul(): the script only accepts "const" or "struct" for
types made of several words, not "unsigned".
I'll fix the script so it can take any word and send a patch next week,
along with some other clean-up fixes for the doc.
Best regards,
Quentin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bpftool doc man page build failure
2019-05-03 16:54 ` Quentin Monnet
@ 2019-05-03 16:56 ` Yonghong Song
0 siblings, 0 replies; 3+ messages in thread
From: Yonghong Song @ 2019-05-03 16:56 UTC (permalink / raw)
To: Quentin Monnet, netdev, bpf@vger.kernel.org, Alexei Starovoitov,
Daniel Borkmann
On 5/3/19 9:54 AM, Quentin Monnet wrote:
> 2019-05-03 16:21 UTC+0000 ~ Yonghong Song <yhs@fb.com>
>> Quentin,
>>
>> I hit the following errors with latest bpf-next.
>>
>> -bash-4.4$ make man
>> GEN bpftool-perf.8
>> GEN bpftool-map.8
>> GEN bpftool.8
>> GEN bpftool-net.8
>> GEN bpftool-feature.8
>> GEN bpftool-prog.8
>> GEN bpftool-cgroup.8
>> GEN bpftool-btf.8
>> GEN bpf-helpers.rst
>> Parsed description of 111 helper function(s)
>> Traceback (most recent call last):
>> File "../../../../scripts/bpf_helpers_doc.py", line 421, in <module>
>> printer.print_all()
>> File "../../../../scripts/bpf_helpers_doc.py", line 187, in print_all
>> self.print_one(helper)
>> File "../../../../scripts/bpf_helpers_doc.py", line 378, in print_one
>> self.print_proto(helper)
>> File "../../../../scripts/bpf_helpers_doc.py", line 356, in print_proto
>> proto = helper.proto_break_down()
>> File "../../../../scripts/bpf_helpers_doc.py", line 56, in
>> proto_break_down
>> 'type' : capture.group(1),
>> AttributeError: 'NoneType' object has no attribute 'group'
>> make: *** [bpf-helpers.rst] Error 1
>> -bash-4.4$ pwd
>> /home/yhs/work/net-next/tools/bpf/bpftool/Documentation
>> -bash-4.4$
>>
>> Maybe a format issue in the comments with some recent helpers?
>>
>> Thanks,
>>
>> Yonghong
>>
>
> Hi Yonghong,
>
> Thanks for the notice! Yes, I observed the same thing not long ago. It
> seems that the Python script breaks on the "unsigned long" pointer
> argument for strtoul(): the script only accepts "const" or "struct" for
> types made of several words, not "unsigned".
>
> I'll fix the script so it can take any word and send a patch next week,
> along with some other clean-up fixes for the doc.
Thanks!
>
> Best regards,
> Quentin
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-03 16:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-03 16:21 bpftool doc man page build failure Yonghong Song
2019-05-03 16:54 ` Quentin Monnet
2019-05-03 16:56 ` Yonghong Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).