From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 682B4C4332F for ; Tue, 8 Nov 2022 09:20:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233452AbiKHJUT (ORCPT ); Tue, 8 Nov 2022 04:20:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232929AbiKHJUR (ORCPT ); Tue, 8 Nov 2022 04:20:17 -0500 Received: from nbd.name (nbd.name [46.4.11.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E211B24080; Tue, 8 Nov 2022 01:20:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YvWOIeTi71vabpR6493wGrzLeEBRKv4j+zJ6SoJE8jA=; b=Ht7+vQH7kQeKDWAOw7T1p8pXNv rmAFDdlK9cAx0c2Yz5jJ2hAm5uHvmRZaOChXwO1HNLB0q6IvIKAE9Cgfs4f4iuqZVnpuYb+OgmH96 wPJ2eCjc3mxdKm9wo3FWETneYsonVU8NW4Hz/39u8+OhRilw1E5sNrOZamR+rHmpmnpM=; Received: from p200300daa72ee1006d973cebf3767a25.dip0.t-ipconnect.de ([2003:da:a72e:e100:6d97:3ceb:f376:7a25] helo=nf.local) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1osKm2-000Tnt-BU; Tue, 08 Nov 2022 10:20:02 +0100 Message-ID: Date: Tue, 8 Nov 2022 10:20:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH 05/14] net: dsa: tag_mtk: assign per-port queues Content-Language: en-US To: Vladimir Oltean Cc: netdev@vger.kernel.org, Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221107185452.90711-1-nbd@nbd.name> <20221107185452.90711-5-nbd@nbd.name> <20221107212209.4pmoctkze4m2ggbv@skbuf> <20221108075816.wsn2olii2lzcq7tf@skbuf> From: Felix Fietkau In-Reply-To: <20221108075816.wsn2olii2lzcq7tf@skbuf> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 08.11.22 08:58, Vladimir Oltean wrote: > On Tue, Nov 08, 2022 at 07:01:29AM +0100, Felix Fietkau wrote: >> On 07.11.22 22:22, Vladimir Oltean wrote: >> > On Mon, Nov 07, 2022 at 07:54:43PM +0100, Felix Fietkau wrote: >> > > Keeps traffic sent to the switch within link speed limits >> > > >> > > Signed-off-by: Felix Fietkau >> > > --- >> > > net/dsa/tag_mtk.c | 3 +++ >> > > 1 file changed, 3 insertions(+) >> > > >> > > diff --git a/net/dsa/tag_mtk.c b/net/dsa/tag_mtk.c >> > > index 415d8ece242a..445d6113227f 100644 >> > > --- a/net/dsa/tag_mtk.c >> > > +++ b/net/dsa/tag_mtk.c >> > > @@ -25,6 +25,9 @@ static struct sk_buff *mtk_tag_xmit(struct sk_buff *skb, >> > > u8 xmit_tpid; >> > > u8 *mtk_tag; >> > > + /* Reserve the first three queues for packets not passed through DSA */ >> > > + skb_set_queue_mapping(skb, 3 + dp->index); >> > > + >> > >> > Should DSA have to care about this detail, or could you rework your >> > mtk_select_queue() procedure to adjust the queue mapping as needed? >> I'm setting the queue here so that I don't have to add the extra overhead of >> parsing the payload in the ethernet driver. >> For passing the queue, I used a similar approach as tag_brcm.c and >> drivers/net/ethernet/broadcom/bcmsysport.c > > I was just asking if you can't add the 3 elsewhere, since the DSA > tagging protocol shouldn't care how many MAC IDs the DSA master has. Sure, that would work. I'll change it in v2. - Felix