From: Edward Cree <ecree.xilinx@gmail.com>
To: Gedalya <gedalya@gedalya.net>, David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH v3] iproute2: color: default to dark background
Date: Wed, 29 May 2024 18:51:01 +0100 [thread overview]
Message-ID: <d8b4ae7b-4759-06d0-9624-7edb93caa09f@gmail.com> (raw)
In-Reply-To: <27cd8235-ac98-46dc-bac8-3a72697281d5@gedalya.net>
On 29/05/2024 17:36, Gedalya wrote:
> That's not possible.
Then in cases where the tool can't determine the answer, it
should not be using colour at all unless explicitly instructed
to do so, either on the command-line or in runtime
configuration like dotfiles, /etc, or envvars.
"In the face of ambiguity, refuse the temptation to guess."[1]
> The fact remains that the code currently makes an
> assumption and I don't see why it is better than
> the other way around.
Because changing it would break it for people for whom it
currently works. That's a regression, and regressions are
worse than existing bugs, ceteris paribus.
"Assess[ing] what is more common" won't change that.
-ed
[1]: https://peps.python.org/pep-0020/#the-zen-of-python
next prev parent reply other threads:[~2024-05-29 17:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 18:43 [PATCH v3] iproute2: color: default to dark background Gedalya Nie
2024-05-29 16:23 ` David Ahern
2024-05-29 16:36 ` Gedalya
2024-05-29 17:51 ` Edward Cree [this message]
2024-05-29 18:11 ` Stephen Hemminger
2024-05-30 22:58 ` Dragan Simic
2024-05-29 18:12 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8b4ae7b-4759-06d0-9624-7edb93caa09f@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=dsahern@kernel.org \
--cc=gedalya@gedalya.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox