* [PATCH net-next 0/2] net: phy: improve genphy_read_status
@ 2019-02-18 19:28 Heiner Kallweit
2019-02-18 19:28 ` [PATCH net-next 1/2] net: phy: remove orphaned register read in genphy_read_status Heiner Kallweit
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Heiner Kallweit @ 2019-02-18 19:28 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, David Miller; +Cc: netdev@vger.kernel.org
Series includes two smaller improvements to genphy_read_status.
Heiner Kallweit (2):
net: phy: remove orphaned register read in genphy_read_status
net: phy: don't use 10BaseT/half as default in genphy_read_status
drivers/net/phy/phy_device.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH net-next 1/2] net: phy: remove orphaned register read in genphy_read_status
2019-02-18 19:28 [PATCH net-next 0/2] net: phy: improve genphy_read_status Heiner Kallweit
@ 2019-02-18 19:28 ` Heiner Kallweit
2019-02-18 19:29 ` [PATCH net-next 2/2] net: phy: don't use 10BaseT/half as default " Heiner Kallweit
2019-02-21 20:58 ` [PATCH net-next 0/2] net: phy: improve genphy_read_status David Miller
2 siblings, 0 replies; 5+ messages in thread
From: Heiner Kallweit @ 2019-02-18 19:28 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, David Miller; +Cc: netdev@vger.kernel.org
After recent changes to genphy_read_status() this orphaned register
read remained as leftover. So remove it.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/phy/phy_device.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 7e71124bb..803197fdd 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -1785,10 +1785,6 @@ int genphy_read_status(struct phy_device *phydev)
mii_lpa_mod_linkmode_lpa_t(phydev->lp_advertising, lpa);
- adv = phy_read(phydev, MII_ADVERTISE);
- if (adv < 0)
- return adv;
-
phydev->speed = SPEED_10;
phydev->duplex = DUPLEX_HALF;
phydev->pause = 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH net-next 2/2] net: phy: don't use 10BaseT/half as default in genphy_read_status
2019-02-18 19:28 [PATCH net-next 0/2] net: phy: improve genphy_read_status Heiner Kallweit
2019-02-18 19:28 ` [PATCH net-next 1/2] net: phy: remove orphaned register read in genphy_read_status Heiner Kallweit
@ 2019-02-18 19:29 ` Heiner Kallweit
2019-02-18 21:08 ` Florian Fainelli
2019-02-21 20:58 ` [PATCH net-next 0/2] net: phy: improve genphy_read_status David Miller
2 siblings, 1 reply; 5+ messages in thread
From: Heiner Kallweit @ 2019-02-18 19:29 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, David Miller; +Cc: netdev@vger.kernel.org
If link partner and we can't agree on any mode, then it doesn't make
sense to pretend we would have agreed on 10/half. Therefore set a
proper default.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/phy/phy_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 803197fdd..4bb3b6c28 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -1785,8 +1785,8 @@ int genphy_read_status(struct phy_device *phydev)
mii_lpa_mod_linkmode_lpa_t(phydev->lp_advertising, lpa);
- phydev->speed = SPEED_10;
- phydev->duplex = DUPLEX_HALF;
+ phydev->speed = SPEED_UNKNOWN;
+ phydev->duplex = DUPLEX_UNKNOWN;
phydev->pause = 0;
phydev->asym_pause = 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next 0/2] net: phy: improve genphy_read_status
2019-02-18 19:28 [PATCH net-next 0/2] net: phy: improve genphy_read_status Heiner Kallweit
2019-02-18 19:28 ` [PATCH net-next 1/2] net: phy: remove orphaned register read in genphy_read_status Heiner Kallweit
2019-02-18 19:29 ` [PATCH net-next 2/2] net: phy: don't use 10BaseT/half as default " Heiner Kallweit
@ 2019-02-21 20:58 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2019-02-21 20:58 UTC (permalink / raw)
To: hkallweit1; +Cc: andrew, f.fainelli, netdev
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Mon, 18 Feb 2019 20:28:04 +0100
> Series includes two smaller improvements to genphy_read_status.
Series applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-21 20:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-18 19:28 [PATCH net-next 0/2] net: phy: improve genphy_read_status Heiner Kallweit
2019-02-18 19:28 ` [PATCH net-next 1/2] net: phy: remove orphaned register read in genphy_read_status Heiner Kallweit
2019-02-18 19:29 ` [PATCH net-next 2/2] net: phy: don't use 10BaseT/half as default " Heiner Kallweit
2019-02-18 21:08 ` Florian Fainelli
2019-02-21 20:58 ` [PATCH net-next 0/2] net: phy: improve genphy_read_status David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).