* [PATCH] net: ethernet: mellanox: return errno instead of 1
@ 2021-12-23 2:24 Qing Wang
2021-12-23 19:34 ` Saeed Mahameed
0 siblings, 1 reply; 2+ messages in thread
From: Qing Wang @ 2021-12-23 2:24 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, David S. Miller, Jakub Kicinski,
netdev, linux-rdma, linux-kernel
Cc: Wang Qing
From: Wang Qing <wangqing@vivo.com>
mlx5e_hv_vhca_stats_create() better return specific error than 1
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c
index d290d72..04cda3d
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c
@@ -142,7 +142,7 @@ int mlx5e_hv_vhca_stats_create(struct mlx5e_priv *priv)
PTR_ERR(agent));
kvfree(priv->stats_agent.buf);
- return IS_ERR_OR_NULL(agent);
+ return agent ? PTR_ERR(agent) : -ENODEV;
}
priv->stats_agent.agent = agent;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ethernet: mellanox: return errno instead of 1
2021-12-23 2:24 [PATCH] net: ethernet: mellanox: return errno instead of 1 Qing Wang
@ 2021-12-23 19:34 ` Saeed Mahameed
0 siblings, 0 replies; 2+ messages in thread
From: Saeed Mahameed @ 2021-12-23 19:34 UTC (permalink / raw)
To: Qing Wang, Saeed Mahameed, Leon Romanovsky, David S. Miller,
Jakub Kicinski, netdev, linux-rdma, linux-kernel
On Wed, 2021-12-22 at 18:24 -0800, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
>
> mlx5e_hv_vhca_stats_create() better return specific error than 1
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c
> index d290d72..04cda3d
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c
> @@ -142,7 +142,7 @@ int mlx5e_hv_vhca_stats_create(struct mlx5e_priv
> *priv)
> PTR_ERR(agent));
>
> kvfree(priv->stats_agent.buf);
> - return IS_ERR_OR_NULL(agent);
> + return agent ? PTR_ERR(agent) : -ENODEV;
the single caller of this function ignores the return value,
I just made a patch to void the return value and added you as Reported-
by.
Thanks !
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-23 19:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-23 2:24 [PATCH] net: ethernet: mellanox: return errno instead of 1 Qing Wang
2021-12-23 19:34 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).