From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [patch net-next v2 00/10] Add support for resource abstraction Date: Thu, 25 Jan 2018 08:38:41 -0700 Message-ID: References: <20171226112359.5313-1-jiri@resnulli.us> <977652df-a0ed-d1a5-f299-1dc433ebd337@mellanox.com> <96389ae0-e038-8a26-84ea-0cf1b9fa0a05@cumulusnetworks.com> <0f861e90-63d3-2666-ef2d-0fc91beae957@mellanox.com> <2f0f6007-64a1-0d0d-eff2-2e5ba6fdb701@cumulusnetworks.com> <20180103181744.GE2067@nanopsycho.orion> <49c72225-6437-54d5-a046-96fff5b65ce9@cumulusnetworks.com> <20180103183636.GF2067@nanopsycho.orion> <5c387961-31c2-33a7-15ff-7bdc7a743b5f@cumulusnetworks.com> <20180125152448.GB2159@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Arkadi Sharshevsky , netdev@vger.kernel.org, roopa@cumulusnetworks.com, davem@davemloft.net, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, ast@kernel.org, daniel@iogearbox.net, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, linville@tuxdriver.com, gospo@broadcom.com, steven.lin1@broadcom.com, yuvalm@mellanox.com, ogerlitz@mellanox.com To: Jiri Pirko Return-path: Received: from mail-pg0-f42.google.com ([74.125.83.42]:35676 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751271AbeAYPip (ORCPT ); Thu, 25 Jan 2018 10:38:45 -0500 Received: by mail-pg0-f42.google.com with SMTP id o13so5284529pgs.2 for ; Thu, 25 Jan 2018 07:38:45 -0800 (PST) In-Reply-To: <20180125152448.GB2159@nanopsycho> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/25/18 8:24 AM, Jiri Pirko wrote: >>>> Now I remember. You wrote it independently and but needed iproute2 be a >>>> delivery vehicle. It uses none of the common infrastructure from >>>> iproute2. Could we make this more difficult .... >>> >>> Feel free to rewrite it to use lib/libnetlink.c. Should not be that >>> hard. Note that at the time I was pushing devlink userspace, tipc also >>> used libmnl as a part of iproute2, so devlink was not the first one. >>> That is why I decided not to rewrite. >>> >>> As of the rest of the "common infrastructure", what exactly do you >>> have in mind? >>> >> >> This is what I am getting at. Apparently, these resource patches for >> devlink require a patched libmnl to work properly. It is wrong for > > What do you mean, "work properly". If there is no patched libmnl, only > thing what happens is that the extack won't be processed and shown. > That is the same behaviour as if you compile iproute2 package without > libmnl - all works, used just don't see extack messages. > > I don't see any problem in that. Do you? I have libmnl installed. I build iproute2. I don't get extended ack messages on devlink failures. That is a problem. That is building a command that is known not to work as it should given the build dependencies.