From: Ying Xue <ying.xue@windriver.com>
To: Kleber Sacilotto de Souza <kleber.souza@canonical.com>,
<netdev@vger.kernel.org>
Cc: Jon Maloy <jon.maloy@ericsson.com>
Subject: Re: [PATCH] tipc: remove unnecessary call to dev_net()
Date: Wed, 6 Sep 2017 20:50:19 +0800 [thread overview]
Message-ID: <d91eb01e-adee-8bce-d419-698020e0af28@windriver.com> (raw)
In-Reply-To: <20170906090806.20931-1-kleber.souza@canonical.com>
On 09/06/2017 05:08 PM, Kleber Sacilotto de Souza wrote:
> The net device is already stored in the 'net' variable, so no need to call
> dev_net() again.
>
> Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
> ---
> net/tipc/bearer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
> index 89cd061c4468..6d6395e0904e 100644
> --- a/net/tipc/bearer.c
> +++ b/net/tipc/bearer.c
> @@ -661,7 +661,7 @@ static int tipc_l2_device_event(struct notifier_block *nb, unsigned long evt,
> break;
> case NETDEV_UNREGISTER:
> case NETDEV_CHANGENAME:
> - bearer_disable(dev_net(dev), b);
> + bearer_disable(net, b);
> break;
> }
> return NOTIFY_OK;
>
next prev parent reply other threads:[~2017-09-06 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 9:08 [PATCH] tipc: remove unnecessary call to dev_net() Kleber Sacilotto de Souza
2017-09-06 12:50 ` Ying Xue [this message]
2017-09-07 4:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d91eb01e-adee-8bce-d419-698020e0af28@windriver.com \
--to=ying.xue@windriver.com \
--cc=jon.maloy@ericsson.com \
--cc=kleber.souza@canonical.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox