From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode Date: Fri, 5 Jan 2018 10:27:52 -0700 Message-ID: References: <20180104073454.11867-1-chrism@mellanox.com> <20180105172523.GD14358@orbyte.nwl.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Phil Sutter , Chris Mi , netdev@vger.kernel.org, gerlitz.or@gmail.com, stephen@networkplumber.org, marcelo.leitner@gmail.com Return-path: Received: from mail-pl0-f45.google.com ([209.85.160.45]:34166 "EHLO mail-pl0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751961AbeAER1v (ORCPT ); Fri, 5 Jan 2018 12:27:51 -0500 Received: by mail-pl0-f45.google.com with SMTP id d21so3405237pll.1 for ; Fri, 05 Jan 2018 09:27:51 -0800 (PST) In-Reply-To: <20180105172523.GD14358@orbyte.nwl.cc> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/5/18 10:25 AM, Phil Sutter wrote: > I wonder whether specifying the batch size is necessary at all. Couldn't > batch mode just collect messages until either EOF or an incompatible > command is encountered which then triggers a commit to kernel? This > might simplify code quite a bit. > agreed.