From: David Ahern <dsahern@gmail.com>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: "David S . Miller" <davem@davemloft.net>,
"Wei Wang" <weiwan@google.com>,
"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
"Maciej Żenczykowski" <maze@google.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv6: Reflect MTU changes on PMTU of exceptions for MTU-less routes
Date: Sun, 4 Mar 2018 18:11:41 -0700 [thread overview]
Message-ID: <d955bd59-e8a7-4c6f-603e-eaa4174a815f@gmail.com> (raw)
In-Reply-To: <20180305001245.23b56b3f@epycfail>
On 3/4/18 4:12 PM, Stefano Brivio wrote:
> On Sat, 3 Mar 2018 12:22:36 +0100
> Stefano Brivio <sbrivio@redhat.com> wrote:
>
>>> And please codify the above expectation as a test under
>>> tools/testing/selftests/net
>>
>> And this, along with v2.
>
> On a second thought: I start thinking it doesn't make much sense,
> especially given the current context of self-tests, to explicitly test
> this, because it's a rather particular corner case.
>
> I think it would make more sense to introduce generic tests first.
> About, say, PMTU, or route exceptions, but not "tunnel causes route
> exception and administrative change doesn't affect PMTU".
>
I would argue corner cases in particular should be documented.
>From the commit message it seems like you took the time to create a test
setup using network namespaces. Throw those commands into a shell script
-- tools/testing/selftests/net/mtu.sh. It can evolve from there.
next prev parent reply other threads:[~2018-03-05 1:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 22:47 [PATCH net v2] ipv6: Reflect MTU changes on PMTU of exceptions for MTU-less routes Stefano Brivio
2018-03-02 18:54 ` [PATCH net] " Maciej Żenczykowski
2018-03-03 11:21 ` Stefano Brivio
2018-03-02 22:39 ` David Ahern
2018-03-03 11:22 ` Stefano Brivio
2018-03-04 23:12 ` Stefano Brivio
2018-03-05 1:11 ` David Ahern [this message]
2018-03-05 12:29 ` Stefano Brivio
2018-03-05 14:14 ` David Miller
2018-03-05 15:27 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d955bd59-e8a7-4c6f-603e-eaa4174a815f@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
--cc=weiwan@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).