netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] dpll: zl3073x: Increase maximum size of flash utility
@ 2025-10-08 14:14 Ivan Vecera
  2025-10-08 15:19 ` Vadim Fedorenko
  2025-10-10  8:40 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Ivan Vecera @ 2025-10-08 14:14 UTC (permalink / raw)
  To: netdev
  Cc: Prathosh Satish, Vadim Fedorenko, Arkadiusz Kubalewski,
	Jiri Pirko, Jakub Kicinski, Przemek Kitszel, open list

Newer firmware bundles contain a flash utility whose size exceeds
the currently allowed limit. Increase the maximum allowed size
to accommodate the newer utility version.

Without this patch:
 # devlink dev flash i2c/1-0070 file fw_nosplit_v3.hex
 Failed to load firmware
 Flashing failed
 Error: zl3073x: FW load failed: [utility] component is too big (11000 bytes)

Fixes: ca017409da694 ("dpll: zl3073x: Add firmware loading functionality")
Suggested-by: Prathosh Satish <Prathosh.Satish@microchip.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
 drivers/dpll/zl3073x/fw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dpll/zl3073x/fw.c b/drivers/dpll/zl3073x/fw.c
index d5418ff74886..def37fe8d9b0 100644
--- a/drivers/dpll/zl3073x/fw.c
+++ b/drivers/dpll/zl3073x/fw.c
@@ -37,7 +37,7 @@ struct zl3073x_fw_component_info {
 static const struct zl3073x_fw_component_info component_info[] = {
 	[ZL_FW_COMPONENT_UTIL] = {
 		.name		= "utility",
-		.max_size	= 0x2300,
+		.max_size	= 0x4000,
 		.load_addr	= 0x20000000,
 		.flash_type	= ZL3073X_FLASH_TYPE_NONE,
 	},
-- 
2.49.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] dpll: zl3073x: Increase maximum size of flash utility
  2025-10-08 14:14 [PATCH net] dpll: zl3073x: Increase maximum size of flash utility Ivan Vecera
@ 2025-10-08 15:19 ` Vadim Fedorenko
  2025-10-10  8:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Vadim Fedorenko @ 2025-10-08 15:19 UTC (permalink / raw)
  To: Ivan Vecera, netdev
  Cc: Prathosh Satish, Arkadiusz Kubalewski, Jiri Pirko, Jakub Kicinski,
	Przemek Kitszel, open list

On 08/10/2025 15:14, Ivan Vecera wrote:
> Newer firmware bundles contain a flash utility whose size exceeds
> the currently allowed limit. Increase the maximum allowed size
> to accommodate the newer utility version.
> 
> Without this patch:
>   # devlink dev flash i2c/1-0070 file fw_nosplit_v3.hex
>   Failed to load firmware
>   Flashing failed
>   Error: zl3073x: FW load failed: [utility] component is too big (11000 bytes)
> 
> Fixes: ca017409da694 ("dpll: zl3073x: Add firmware loading functionality")
> Suggested-by: Prathosh Satish <Prathosh.Satish@microchip.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>   drivers/dpll/zl3073x/fw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dpll/zl3073x/fw.c b/drivers/dpll/zl3073x/fw.c
> index d5418ff74886..def37fe8d9b0 100644
> --- a/drivers/dpll/zl3073x/fw.c
> +++ b/drivers/dpll/zl3073x/fw.c
> @@ -37,7 +37,7 @@ struct zl3073x_fw_component_info {
>   static const struct zl3073x_fw_component_info component_info[] = {
>   	[ZL_FW_COMPONENT_UTIL] = {
>   		.name		= "utility",
> -		.max_size	= 0x2300,
> +		.max_size	= 0x4000,
>   		.load_addr	= 0x20000000,
>   		.flash_type	= ZL3073X_FLASH_TYPE_NONE,
>   	},

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] dpll: zl3073x: Increase maximum size of flash utility
  2025-10-08 14:14 [PATCH net] dpll: zl3073x: Increase maximum size of flash utility Ivan Vecera
  2025-10-08 15:19 ` Vadim Fedorenko
@ 2025-10-10  8:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-10-10  8:40 UTC (permalink / raw)
  To: Ivan Vecera
  Cc: netdev, Prathosh.Satish, vadim.fedorenko, arkadiusz.kubalewski,
	jiri, kuba, przemyslaw.kitszel, linux-kernel

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Wed,  8 Oct 2025 16:14:18 +0200 you wrote:
> Newer firmware bundles contain a flash utility whose size exceeds
> the currently allowed limit. Increase the maximum allowed size
> to accommodate the newer utility version.
> 
> Without this patch:
>  # devlink dev flash i2c/1-0070 file fw_nosplit_v3.hex
>  Failed to load firmware
>  Flashing failed
>  Error: zl3073x: FW load failed: [utility] component is too big (11000 bytes)
> 
> [...]

Here is the summary with links:
  - [net] dpll: zl3073x: Increase maximum size of flash utility
    https://git.kernel.org/netdev/net/c/f3426ac54c42

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-10  8:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-08 14:14 [PATCH net] dpll: zl3073x: Increase maximum size of flash utility Ivan Vecera
2025-10-08 15:19 ` Vadim Fedorenko
2025-10-10  8:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).