From: Ping-Ke Shih <pkshih@realtek.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "kvalo@kernel.org" <kvalo@kernel.org>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"colin.king@intel.com" <colin.king@intel.com>
Subject: RE: [PATCH net-next 3/8] wifi: rtlwifi: remove always-true condition pointed out by GCC 12
Date: Tue, 24 May 2022 00:41:12 +0000 [thread overview]
Message-ID: <d9690c0a1e444dcdbab8a9c1eb0f98df@realtek.com> (raw)
In-Reply-To: <20220523085701.3d7550ff@kernel.org>
> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Monday, May 23, 2022 11:57 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: kvalo@kernel.org; johannes@sipsolutions.net; netdev@vger.kernel.org; linux-wireless@vger.kernel.org;
> keescook@chromium.org; colin.king@intel.com
> Subject: Re: [PATCH net-next 3/8] wifi: rtlwifi: remove always-true condition pointed out by GCC 12
>
> On Mon, 23 May 2022 02:35:32 +0000 Ping-Ke Shih wrote:
> > This is a typo since initial commit. Correct it by
> > - value[0] != NULL)
> > + value[0][0] != 0)
> >
> > So, NACK this patch.
>
> Too, late, the patches were already applied, sorry. Please post a fixup.
I have sent a patch to correct it:
https://lore.kernel.org/linux-wireless/20220524003750.3989-1-pkshih@realtek.com/T/#u
Please take it into net-next tree.
Thank you
Ping-Ke
next prev parent reply other threads:[~2022-05-24 0:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 19:43 [PATCH net-next 0/8] Fix/silence GCC 12 warnings in drivers/net/wireless/ Jakub Kicinski
2022-05-20 19:43 ` [PATCH net-next 1/8] wifi: plfxlc: remove redundant NULL-check for GCC 12 Jakub Kicinski
2022-05-20 19:43 ` [PATCH net-next 2/8] wifi: ath9k: silence array-bounds warning on " Jakub Kicinski
2022-05-21 6:58 ` Kalle Valo
2022-05-21 17:53 ` Jakub Kicinski
2022-05-22 12:06 ` Kalle Valo
2022-05-23 19:31 ` Kees Cook
2022-05-20 19:43 ` [PATCH net-next 3/8] wifi: rtlwifi: remove always-true condition pointed out by " Jakub Kicinski
2022-05-23 2:35 ` Ping-Ke Shih
2022-05-23 15:57 ` Jakub Kicinski
2022-05-24 0:41 ` Ping-Ke Shih [this message]
2022-05-20 19:43 ` [PATCH net-next 4/8] wifi: ath6k: silence false positive -Wno-dangling-pointer warning on " Jakub Kicinski
2022-05-20 19:43 ` [PATCH net-next 5/8] wifi: iwlwifi: use unsigned to silence a GCC 12 warning Jakub Kicinski
2022-05-20 19:43 ` [PATCH net-next 6/8] wifi: brcmfmac: work around a GCC 12 -Warray-bounds warning Jakub Kicinski
2022-05-20 19:43 ` [PATCH net-next 7/8] wifi: libertas: silence " Jakub Kicinski
2022-05-21 22:03 ` Johannes Berg
2022-05-22 16:56 ` Jakub Kicinski
2022-05-20 19:43 ` [PATCH net-next 8/8] wifi: carl9170: " Jakub Kicinski
2022-05-20 19:58 ` Christian Lamparter
2022-05-22 12:19 ` [PATCH net-next 0/8] Fix/silence GCC 12 warnings in drivers/net/wireless/ Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9690c0a1e444dcdbab8a9c1eb0f98df@realtek.com \
--to=pkshih@realtek.com \
--cc=colin.king@intel.com \
--cc=johannes@sipsolutions.net \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).