From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [Patch net] rds: mark bound socket with SOCK_RCU_FREE Date: Mon, 10 Sep 2018 17:56:34 -0700 Message-ID: References: <20180910222422.19470-1-xiyou.wangcong@gmail.com> <20180910233007.GJ4668@oracle.com> <20180911000437.GK4668@oracle.com> <17b2b2b8-12ce-076e-a961-2a8bee1d021f@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Sowmini Varadhan , Linux Kernel Network Developers , rds-devel@oss.oracle.com To: Cong Wang Return-path: Received: from aserp2120.oracle.com ([141.146.126.78]:56938 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbeIKFxS (ORCPT ); Tue, 11 Sep 2018 01:53:18 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 9/10/2018 5:45 PM, Cong Wang wrote: > On Mon, Sep 10, 2018 at 5:26 PM Santosh Shilimkar > wrote: >> Would you mind posting an updated patch please with call_rcu and >> above extended RCU grace period with rcu_read_lock. Thanks !! > > If you prefer to fix _two_ problems in one patch, sure. > > For the record, the bug this patch fixes is NOT same with the one > in rds_find_bound(), because there is no rds_find_bound() in > the backtrace. If you want to see the full backtrace, here it is: > > https://marc.info/?l=linux-netdev&m=153644444808962&w=2 > > This is why I believe they are two problems. > > Whether fixing two problems in one patch or two patches is > merely a preference, I leave it up to you. > I had a partial fix as well in past but since it wasn't covering complete window, it was abandoned. Since we know the other race, it would be best to address it together and hence requested a combine patch. Thanks for help !! Regards, Santosh