netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Andrea Mayer <andrea.mayer@uniroma2.it>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
	David Ahern <dsahern@kernel.org>,
	David Lebrun <david.lebrun@uclouvain.be>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Ahmed Abdelsalam <ahabdels.dev@gmail.com>,
	Paolo Lungaroni <paolo.lungaroni@uniroma2.it>,
	Stefano Salsano <stefano.salsano@uniroma2.it>
Subject: Re: [net] ipv6: sr: fix missing sk_buff release in seg6_input_core
Date: Sat, 18 May 2024 17:47:12 +0200	[thread overview]
Message-ID: <d97d966e-bc95-4d43-83ad-b368ed7d7e71@web.de> (raw)
In-Reply-To: <20240517164541.17733-1-andrea.mayer@uniroma2.it>

* The message subject would have been a bit nicer with the key word “PATCH”.

* How do you think about to append parentheses to the function name?


…
> The proposed patch addresses the identified memory leak by …

Will a corresponding imperative wording be more desirable for
an improved change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94

Regards,
Markus

  parent reply	other threads:[~2024-05-18 15:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-17 16:45 [net] ipv6: sr: fix missing sk_buff release in seg6_input_core Andrea Mayer
2024-05-17 19:23 ` Simon Horman
2024-05-17 22:04 ` David Ahern
2024-05-18 15:47 ` Markus Elfring [this message]
2024-05-20 10:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d97d966e-bc95-4d43-83ad-b368ed7d7e71@web.de \
    --to=markus.elfring@web.de \
    --cc=ahabdels.dev@gmail.com \
    --cc=andrea.mayer@uniroma2.it \
    --cc=davem@davemloft.net \
    --cc=david.lebrun@uclouvain.be \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=paolo.lungaroni@uniroma2.it \
    --cc=stefano.salsano@uniroma2.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).