From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53387C2D0F4 for ; Wed, 8 Apr 2020 20:52:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 111EC206F7 for ; Wed, 8 Apr 2020 20:52:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sFpWlM5w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729298AbgDHUwk (ORCPT ); Wed, 8 Apr 2020 16:52:40 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:38650 "EHLO mail-wm1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729231AbgDHUwj (ORCPT ); Wed, 8 Apr 2020 16:52:39 -0400 Received: by mail-wm1-f42.google.com with SMTP id f20so1290230wmh.3 for ; Wed, 08 Apr 2020 13:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3XbbyHHJ0IZf1sgUmuQvknob5+Jn1cbPagotsX3JEgQ=; b=sFpWlM5wymWPfpcN4a1YI8YV+vKnmtVkm+bHIazW6m30cmXKRiodUCs+EtZMaw7Ke9 VyV7+GlID9nS/fPo++vMoVVgGgZQ/drSbPNdT1LkegLrv0YFs2U/I8ANQH323lkvgK6L eVkH8FqKP+dvhALOKNVU3raz3oRfd63hctQ54jsQLrRnwhEJSZKge1B5uzS/5TjUGhUw 4hsu2z2SjVwvc2GsQBm9GCrSyFSQmNoHe081ogfHb9LNUa7HrPoyBk3FwIG0audn9lSo 0AOriahz96qlsvpyotyHpcF/lNUT7MhIBmJoXcYTk2s5lBe7R8ck95y/WiiEWbWj06vY VlXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=3XbbyHHJ0IZf1sgUmuQvknob5+Jn1cbPagotsX3JEgQ=; b=KeZNV9N5Lfm+rzWSIbhaZFYygTMss1BvteJD4raXQzbJCcBjm1MbQeOyz7vVz0ycEW HFSApnoubVHtCoWCpDtoZ6sgWdmzX50Srp9PYrdp/oRtKRpKeC7/3KDd7DZ/663yOSoU 0m3lJBeUMPn3I6ktsZ1ep92FMwBeoHj+gjwbeS1iK9G6QSy7dgagqWkVqOl9CiFFElQk xqdC8xeXyGdxZFb0+JvxBA5MEZJWrLZjQvNgDVEGXXGA8pYT7eqVOsIRWxTploW4U2Ez hsvCk2v/D8QEOuNpDjiPgRz4Xfn0RvoomcExhfAtorOpercj68DnaV6FEDIIgTRff3Qg Z8Xg== X-Gm-Message-State: AGi0PuZM6rTZZe33lFsdbLcs+toiDTlY68LlT4YpBdiLt5rryChK7uy7 7KxwpC2dnRVTGL5jfPbbwuFP6wZx X-Google-Smtp-Source: APiQypK1vpK6dfzamY4zQ4vHDND/i11nUZPzEXpMNZF1uzc331jm/gKy6ewFCEc33sZH8GyxWbYQzQ== X-Received: by 2002:a7b:cc01:: with SMTP id f1mr6810136wmh.39.1586379156895; Wed, 08 Apr 2020 13:52:36 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id n6sm11034328wrs.81.2020.04.08.13.52.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2020 13:52:36 -0700 (PDT) Subject: Re: Changing devlink port flavor dynamically for DSA To: Vladimir Oltean Cc: netdev , Andrew Lunn , Vivien Didelot , Ido Schimmel , Jiri Pirko , Jakub Kicinski References: <5efb57cc-d783-ed70-73c1-3114f4952520@gmail.com> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Wed, 8 Apr 2020 13:52:33 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/8/2020 1:10 PM, Vladimir Oltean wrote: > On Wed, 8 Apr 2020 at 23:05, Florian Fainelli wrote: >> >> >> >> On 4/8/2020 12:51 PM, Vladimir Oltean wrote: >>> Hi Florian, >>> >>> On Sun, 5 Apr 2020 at 23:42, Florian Fainelli wrote: >>>> >>>> Hi all, >>>> >>>> On a BCM7278 system, we have two ports of the switch: 5 and 8, that >>>> connect to separate Ethernet MACs that the host/CPU can control. In >>>> premise they are both interchangeable because the switch supports >>>> configuring the management port to be either 5 or 8 and the Ethernet >>>> MACs are two identical instances. >>>> >>>> The Ethernet MACs are scheduled differently across the memory controller >>>> (they have different bandwidth and priority allocations) so it is >>>> desirable to select an Ethernet MAC capable of sustaining bandwidth and >>>> latency for host networking. Our current (in the downstream kernel) use >>>> case is to expose port 5 solely as a control end-point to the user and >>>> leave it to the user how they wish to use the Ethernet MAC behind port >>>> 5. Some customers use it to bridge Wi-Fi traffic, some simply keep it >>>> disabled. Port 5 of that switch does not make use of Broadcom tags in >>>> that case, since ARL-based forwarding works just fine. >>>> >>>> The current Device Tree representation that we have for that system >>>> makes it possible for either port to be elected as the CPU port from a >>>> DSA perspective as they both have an "ethernet" phandle property that >>>> points to the appropriate Ethernet MAC node, because of that the DSA >>>> framework treats them as CPU ports. >>>> >>>> My current line of thinking is to permit a port to be configured as >>>> either "cpu" or "user" flavor and do that through devlink. This can >>>> create some challenges but hopefully this also paves the way for finally >>>> supporting "multi-CPU port" configurations. I am thinking something like >>>> this would be how I would like it to be configured: >>>> >>>> # First configure port 8 as the new CPU port >>>> devlink port set pci/0000:01:00.0/8 type cpu >>>> # Now unmap port 5 from being a CPU port >>>> devlink port set pci/0000:01:00.0/1 type eth >>>> >>>> and this would do a simple "swap" of all user ports being now associated >>>> with port 8, and no longer with port 5, thus permitting port 5 from >>>> becoming a standard user port. Or maybe, we need to do this as an atomic >>>> operation in order to avoid a switch being configured with no CPU port >>>> anymore, so something like this instead: >>>> >>>> devlink port set pci/0000:01:00.0/5 type eth mgmt pci/0000:01:00.0/8 >>>> >>>> The latter could also be used to define groups of ports within a switch >>>> that has multiple CPU ports, e.g.: >>>> >>>> # Ports 1 through 4 "bound" to CPU port 5: >>>> >>>> for i in $(seq 0 3) >>>> do >>>> devlink port set pci/0000:01:00.0/$i type eth mgmt pci/0000:01:00.0/5 >>>> done >>>> >>>> # Ports 7 bound to CPU port 8: >>>> >>>> devlink port set pci/0000:01:00.0/1 type eth mgmt pci/0000:01:00.0/8 >>>> >>>> Let me know what you think! >>>> >>>> Thanks >>>> -- >>>> Florian >>> >>> What is missing from your argumentation is what would the new devlink >>> mechanism of changing the CPU port bring for your particular use case. >>> I mean you can already remove the "ethernet" device tree property from >>> port 5 and end up exactly with the configuration that you want, no? >> >> That's what I do in our downstream tree for now, should I submit this >> upstream? I doubt it would be accepted. >> -- >> Florian > > This is exactly what we do for the NXP LS1028A (ocelot/felix driver), > where we enable just one of the 2 CPU ports by default (and the other > one, just as a simple user port in the very few situations that > require it): > https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi#L943 > Although to be fair, for LS1028A we can't even dream of enabling DSA > tagging on both CPU ports at the same time, since there is a hardware > limitation in place that only a single port may carry DSA tags at any > given moment in time. The firmware is provided by the boot loader in my case, and while it can be changed, dealing with incompatibilities is a support burden, so instead, I have two lines of code in the sf2 driver to delete the DT property and that gets me going. I still think there is value in being able to assign groups of user ports to a specific CPU/management port (maybe even DSA, say if we supported trunking/bonding at some point). -- Florian