* [PATCH net-next] bnxt_en: Fix build break on non-x86 platforms
@ 2026-01-13 18:34 Michael Chan
2026-01-14 0:00 ` Vadim Fedorenko
2026-01-16 4:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Michael Chan @ 2026-01-13 18:34 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, kuba, pabeni, andrew+netdev, pavan.chebbi,
andrew.gospodarek, sfr, kernel test robot
From: Pavan Chebbi <pavan.chebbi@broadcom.com>
Commit c470195b989fe added .getcrosststamp() interface where
the code uses boot_cpu_has() function which is available only
in x86 platforms. This fails the build on any other platform.
Since the interface is going to be supported only on x86 anyway,
we can simply compile out the entire support on non-x86 platforms.
Cover the .getcrosststamp support under CONFIG_X86
Fixes: c470195b989f ("bnxt_en: Add PTP .getcrosststamp() interface to get device/host times")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202601111808.WnBJCuWI-lkp@intel.com
Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
index 75ad385f5f79..ad89c5fa9b40 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
@@ -882,6 +882,7 @@ void bnxt_tx_ts_cmp(struct bnxt *bp, struct bnxt_napi *bnapi,
}
}
+#ifdef CONFIG_X86
static int bnxt_phc_get_syncdevicetime(ktime_t *device,
struct system_counterval_t *system,
void *ctx)
@@ -924,6 +925,7 @@ static int bnxt_ptp_getcrosststamp(struct ptp_clock_info *ptp_info,
return get_device_system_crosststamp(bnxt_phc_get_syncdevicetime,
ptp, NULL, xtstamp);
}
+#endif /* CONFIG_X86 */
static const struct ptp_clock_info bnxt_ptp_caps = {
.owner = THIS_MODULE,
@@ -1137,9 +1139,11 @@ int bnxt_ptp_init(struct bnxt *bp)
if (bnxt_ptp_pps_init(bp))
netdev_err(bp->dev, "1pps not initialized, continuing without 1pps support\n");
}
+#ifdef CONFIG_X86
if ((bp->fw_cap & BNXT_FW_CAP_PTP_PTM) && pcie_ptm_enabled(bp->pdev) &&
boot_cpu_has(X86_FEATURE_ART))
ptp->ptp_info.getcrosststamp = bnxt_ptp_getcrosststamp;
+#endif /* CONFIG_X86 */
ptp->ptp_clock = ptp_clock_register(&ptp->ptp_info, &bp->pdev->dev);
if (IS_ERR(ptp->ptp_clock)) {
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] bnxt_en: Fix build break on non-x86 platforms
2026-01-13 18:34 [PATCH net-next] bnxt_en: Fix build break on non-x86 platforms Michael Chan
@ 2026-01-14 0:00 ` Vadim Fedorenko
2026-01-16 4:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Vadim Fedorenko @ 2026-01-14 0:00 UTC (permalink / raw)
To: Michael Chan, davem
Cc: netdev, edumazet, kuba, pabeni, andrew+netdev, pavan.chebbi,
andrew.gospodarek, sfr, kernel test robot
On 13/01/2026 18:34, Michael Chan wrote:
> From: Pavan Chebbi <pavan.chebbi@broadcom.com>
>
> Commit c470195b989fe added .getcrosststamp() interface where
> the code uses boot_cpu_has() function which is available only
> in x86 platforms. This fails the build on any other platform.
>
> Since the interface is going to be supported only on x86 anyway,
> we can simply compile out the entire support on non-x86 platforms.
>
> Cover the .getcrosststamp support under CONFIG_X86
>
> Fixes: c470195b989f ("bnxt_en: Add PTP .getcrosststamp() interface to get device/host times")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202601111808.WnBJCuWI-lkp@intel.com
> Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
> Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] bnxt_en: Fix build break on non-x86 platforms
2026-01-13 18:34 [PATCH net-next] bnxt_en: Fix build break on non-x86 platforms Michael Chan
2026-01-14 0:00 ` Vadim Fedorenko
@ 2026-01-16 4:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-01-16 4:00 UTC (permalink / raw)
To: Michael Chan
Cc: davem, netdev, edumazet, kuba, pabeni, andrew+netdev,
pavan.chebbi, andrew.gospodarek, sfr, lkp
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 13 Jan 2026 10:34:22 -0800 you wrote:
> From: Pavan Chebbi <pavan.chebbi@broadcom.com>
>
> Commit c470195b989fe added .getcrosststamp() interface where
> the code uses boot_cpu_has() function which is available only
> in x86 platforms. This fails the build on any other platform.
>
> Since the interface is going to be supported only on x86 anyway,
> we can simply compile out the entire support on non-x86 platforms.
>
> [...]
Here is the summary with links:
- [net-next] bnxt_en: Fix build break on non-x86 platforms
https://git.kernel.org/netdev/net-next/c/dc634118aaa0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-16 4:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-13 18:34 [PATCH net-next] bnxt_en: Fix build break on non-x86 platforms Michael Chan
2026-01-14 0:00 ` Vadim Fedorenko
2026-01-16 4:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox