From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4DC322A80D; Wed, 29 Apr 2026 01:57:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777427867; cv=none; b=ZZq2XVAozshRRkwlhmJ/SuzIbSm/oEA4KCwxhPL7/p66/VUkjn5FkdmowbEfC4fuPsdOmSFzQfwiY0WyLT0T5ugu7aPdyMK5joGkTWFPsnZJ3dGCRZILO32HchEV3yvVjDvR8Wc6Ehk1+0xq1ZMUVyTuMOX1qz7sTxy5arT3SU8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777427867; c=relaxed/simple; bh=1OCg6gv0s9a4rmryuF3WO72m1ZcTPRKGn69AF8kNNqU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O2QQzN7NU+UveQzCrfoUg/uE9TgZHzifNwnMM4FhMx06OUGVO+aSFDpqBi0mVZFD3ZdVwUiVAlZyMqvKL8n4mMuthJP/0tD72rxYLPGHlY7xYN0CUQvsIX9rtpdUfdiGRK7qxLw8uSQ2XrVdWN6S5cJnCzHksiBhY+LQjRwFP6w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=cjZsd7oV; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="cjZsd7oV" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ABXuMMIgTfQ5OtNDHGIn2rIDcXtUvbW4R29/GTY4DW8=; b=cjZsd7oVat20nuCKlTwBoZA64P xdGQiijMUUs9Pk4RZ5RACN3M8b9+/VuD/LxIKQCKIRi8sW1c8ONbDnvH6pMupRwfPRBSo1I0qpCSd P0bvL+JeaDOvROwsLHIUyH1lO8uzq3/ZMcEcOiHOqTCam4zNnm+kiho/bFbPpUD+Z8hk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wHuBH-000RqS-T8; Wed, 29 Apr 2026 03:57:39 +0200 Date: Wed, 29 Apr 2026 03:57:39 +0200 From: Andrew Lunn To: Birger Koblitz Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chih Kai Hsu Subject: Re: [PATCH net-next 4/4] r8152: Add firmware upload capability for RTL8157/RTL8159 Message-ID: References: <20260428-rtl8159_net_next-v1-0-52d03927b46f@birger-koblitz.de> <20260428-rtl8159_net_next-v1-4-52d03927b46f@birger-koblitz.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260428-rtl8159_net_next-v1-4-52d03927b46f@birger-koblitz.de> On Tue, Apr 28, 2026 at 05:47:24AM +0200, Birger Koblitz wrote: > The RTL8159 requires firmware for its PHY in order to work at > connection speeds > 5GBit. Add support for uploading firmware for > the PHYs using the existing rtl8152_apply_firmware() function > in r8157_hw_phy_cfg() and set up the correct names for the firmware > files. > > If no firmware is found, both the RTL8157 and the RTL8159 will continue > to work. > > Signed-off-by: Birger Koblitz > --- > drivers/net/usb/r8152.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index 08cc3c1dae0facb2400890ba4d093c97ed56d40b..56e00fe6f32405ce753df3e03e54a7daaf1a29ac 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -4663,10 +4663,11 @@ static bool rtl8152_is_fw_phy_speed_up_ok(struct r8152 *tp, struct fw_phy_speed_ > case RTL_VER_11: > case RTL_VER_12: > case RTL_VER_14: > - case RTL_VER_16: > goto out; > case RTL_VER_13: > case RTL_VER_15: > + case RTL_VER_16: > + case RTL_VER_17: Is that a bug fix? Andrew