From: Jacob Keller <jacob.e.keller@intel.com>
To: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>,
<aleksandr.loktionov@intel.com>
Cc: <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<edumazet@google.com>, <horms@kernel.org>,
<intel-wired-lan@lists.osuosl.org>, <jesse.brandeburg@intel.com>,
<kuba@kernel.org>, <netdev@vger.kernel.org>, <pabeni@redhat.com>,
<przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH net v4 4/4] ice: skip unnecessary VF reset when setting trust
Date: Mon, 27 Apr 2026 16:10:38 -0700 [thread overview]
Message-ID: <d9e23405-85b8-45aa-bab8-3842647f0297@intel.com> (raw)
In-Reply-To: <20260427075948.870208-1-jtornosm@redhat.com>
On 4/27/2026 12:59 AM, Jose Ignacio Tornos Martinez wrote:
> Hello Aleksandr,
>
>> One more nit, kdoc should end with '*/' not '**/'
> Ok, in the current code there are already some functions with headers
> ending in '**/' and others with '*/' , the functions I have added or
> changed the prototype in the series will all end in '*/' as you say,
> in the next version.
>
> Thanks
>
> Best regards
> Jose Ignacio
>
Yep, thanks! There are some legacy mistakes, but we (netdev) don't
typically do mass patch cleanups for changes like that because the churn
is considered more problematic than the fix.
However, the preference is to use the preferred/correct version on new
code or when changing existing code.
Thanks,
Jake
next prev parent reply other threads:[~2026-04-27 23:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 13:04 [PATCH net v4 0/4] Fix i40e/ice/iavf VF bonding after netdev lock changes Jose Ignacio Tornos Martinez
2026-04-23 13:04 ` [PATCH net v4 1/4] iavf: return EBUSY if reset in progress or not ready during MAC change Jose Ignacio Tornos Martinez
2026-04-23 13:14 ` Loktionov, Aleksandr
2026-04-23 13:04 ` [PATCH net v4 2/4] i40e: skip unnecessary VF reset when setting trust Jose Ignacio Tornos Martinez
2026-04-23 13:14 ` Loktionov, Aleksandr
2026-04-27 16:25 ` Simon Horman
2026-04-23 13:04 ` [PATCH net v4 3/4] iavf: send MAC change request synchronously Jose Ignacio Tornos Martinez
2026-04-23 13:14 ` Loktionov, Aleksandr
2026-04-27 9:23 ` Przemek Kitszel
2026-04-27 11:34 ` Jose Ignacio Tornos Martinez
2026-04-27 16:43 ` Simon Horman
2026-04-23 13:04 ` [PATCH net v4 4/4] ice: skip unnecessary VF reset when setting trust Jose Ignacio Tornos Martinez
2026-04-23 13:17 ` Loktionov, Aleksandr
2026-04-24 10:32 ` Jose Ignacio Tornos Martinez
2026-04-24 10:37 ` Loktionov, Aleksandr
2026-04-24 12:40 ` Jose Ignacio Tornos Martinez
2026-04-24 16:05 ` Loktionov, Aleksandr
2026-04-27 7:59 ` Jose Ignacio Tornos Martinez
2026-04-27 23:10 ` Jacob Keller [this message]
2026-04-27 16:50 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9e23405-85b8-45aa-bab8-3842647f0297@intel.com \
--to=jacob.e.keller@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jtornosm@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox