From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [RFC PATCH] inet: frags: lowpan_rhash_params can be static Date: Sat, 31 Mar 2018 06:46:39 -0700 Message-ID: References: <20180331005309.179376-9-edumazet@google.com> <20180331074707.GA123200@ivb42> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: kbuild-all@01.org, "David S . Miller" , netdev , Florian Westphal , Herbert Xu , Thomas Graf , Jesper Dangaard Brouer , Alexander Aring , Stefan Schmidt , Kirill Tkhai , Eric Dumazet To: kbuild test robot , Eric Dumazet Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:42060 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965AbeCaNqm (ORCPT ); Sat, 31 Mar 2018 09:46:42 -0400 Received: by mail-pg0-f67.google.com with SMTP id f10so6665899pgs.9 for ; Sat, 31 Mar 2018 06:46:42 -0700 (PDT) In-Reply-To: <20180331074707.GA123200@ivb42> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 03/31/2018 12:47 AM, kbuild test robot wrote: > > Fixes: b051dbce5e50 ("inet: frags: use rhashtables for reassembly units") > Signed-off-by: Fengguang Wu > --- > reassembly.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ieee802154/6lowpan/reassembly.c b/net/ieee802154/6lowpan/reassembly.c > index dd743c2..0fa0121 100644 > --- a/net/ieee802154/6lowpan/reassembly.c > +++ b/net/ieee802154/6lowpan/reassembly.c > @@ -597,7 +597,7 @@ static int lowpan_obj_cmpfn(struct rhashtable_compare_arg *arg, const void *ptr) > return !!memcmp(&fq->key, key, sizeof(*key)); > } > > -const struct rhashtable_params lowpan_rhash_params = { > +static const struct rhashtable_params lowpan_rhash_params = { > .head_offset = offsetof(struct inet_frag_queue, node), > .hashfn = lowpan_key_hashfn, > .obj_hashfn = lowpan_obj_hashfn, > Thanks for the report/patch. I will squash this in the V4 submission.