Re: [net-next PATCH] net/rds: Return proper "tos" value to user-space

[Zhu Yanjun <yanjun.zhu@oracle.com>]

在 2019/3/9 6:37, Gerd Rausch 写道:
> On 07/03/2019 17.37, santosh.shilimkar@oracle.com wrote:
>>> --- a/net/rds/connection.c
>>> +++ b/net/rds/connection.c
>>> @@ -736,6 +736,7 @@ static int rds_conn_info_visitor(struct rds_conn_path *cp, void *buffer)
>>>        cinfo->next_rx_seq = cp->cp_next_rx_seq;
>>>        cinfo->laddr = conn->c_laddr.s6_addr32[3];
>>>        cinfo->faddr = conn->c_faddr.s6_addr32[3];
>>> +    cinfo->tos = conn->c_tos;
>>>        strncpy(cinfo->transport, conn->c_trans->t_name,
>>>            sizeof(cinfo->transport));
>>>        cinfo->flags = 0;
>>>
>> Transport function populates it "iinfo->tos" so 'rds-info -I'
>> already should be showing the correct output but we should popullate
>> it here to for socket option so looks good
>>
> "rds-info -I" did show the correct output, but
>
> "rds-info -n" did not:

Thanks.

Reviewed-by: Zhu Yanjun <yanjun.zhu@oracle.com>


>
> % rds-info -n
> RDS Connections:
>        LocalAddr      RemoteAddr  Tos           NextTX           NextRX Flgs
>    192.168.253.2   192.168.253.1  159            46940            46264 --C-
>
>> Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
>>
> Thanks,
>
>    Gerd