From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3E5C43381 for ; Fri, 8 Mar 2019 23:57:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5508720684 for ; Fri, 8 Mar 2019 23:57:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="iSGTmpQI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726446AbfCHX5b (ORCPT ); Fri, 8 Mar 2019 18:57:31 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:56692 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbfCHX5b (ORCPT ); Fri, 8 Mar 2019 18:57:31 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x28NoTia071233; Fri, 8 Mar 2019 23:57:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=StJYxTbFdTBPOgdW7wcb41iO8j2jgzLqRuVmCdiNaeQ=; b=iSGTmpQIo+DUzlxD8MNAgUdoJjKLVglSi7ht2r2rHiNEkLiOt/v6YpYO+bx5kBffA88t IL612ydLLSUb1PaISNWQm2dqu1odB6PNTOJMI8GXFC3BI5GmI9bHULzliYYHf1u7Cvxa VnX5vwrlZ74EnIO0uoFjSpgrt2q3h+qN/U54YKALASU1J9d1N2QfuZXA2XjIlu7nPuWT xHAPzSr8J/Rr06E54CC92RzaYznMRLKCFA/EQB+o/5ACd0VEkR0j7zQ3OfNE853IzXNZ A8DFCsR3wmqopAUMvpDo+Z5513AyQiC0MNccNPHWY4KN9QdBPREKAJ7PaTuFdvc1/gvm SA== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2qyh8uu28t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 Mar 2019 23:57:27 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x28NvQxY012556 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Mar 2019 23:57:26 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x28NvPN2003030; Fri, 8 Mar 2019 23:57:26 GMT Received: from [192.168.1.8] (/221.223.11.111) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 08 Mar 2019 15:57:25 -0800 Subject: Re: [net-next PATCH] net/rds: Return proper "tos" value to user-space To: Gerd Rausch , "santosh.shilimkar@oracle.com" , netdev@vger.kernel.org Cc: David Miller References: <1549325089-16572-4-git-send-email-santosh.shilimkar@oracle.com> <20190307220106.9099-1-gerd.rausch@oracle.com> <52a2653e-6ac6-bdc7-5e6e-a7763eef968d@oracle.com> From: Zhu Yanjun Message-ID: Date: Sat, 9 Mar 2019 07:57:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <52a2653e-6ac6-bdc7-5e6e-a7763eef968d@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9189 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903080164 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 在 2019/3/9 6:37, Gerd Rausch 写道: > On 07/03/2019 17.37, santosh.shilimkar@oracle.com wrote: >>> --- a/net/rds/connection.c >>> +++ b/net/rds/connection.c >>> @@ -736,6 +736,7 @@ static int rds_conn_info_visitor(struct rds_conn_path *cp, void *buffer) >>>       cinfo->next_rx_seq = cp->cp_next_rx_seq; >>>       cinfo->laddr = conn->c_laddr.s6_addr32[3]; >>>       cinfo->faddr = conn->c_faddr.s6_addr32[3]; >>> +    cinfo->tos = conn->c_tos; >>>       strncpy(cinfo->transport, conn->c_trans->t_name, >>>           sizeof(cinfo->transport)); >>>       cinfo->flags = 0; >>> >> Transport function populates it "iinfo->tos" so 'rds-info -I' >> already should be showing the correct output but we should popullate >> it here to for socket option so looks good >> > "rds-info -I" did show the correct output, but > > "rds-info -n" did not: Thanks. Reviewed-by: Zhu Yanjun > > % rds-info -n > RDS Connections: > LocalAddr RemoteAddr Tos NextTX NextRX Flgs > 192.168.253.2 192.168.253.1 159 46940 46264 --C- > >> Acked-by: Santosh Shilimkar >> > Thanks, > > Gerd