Re: [PATCH iwl-next v1 04/15] ice: add VF queue ena/dis helper functions

[Przemek Kitszel <przemyslaw.kitszel@intel.com>]

>> +/*
> Please use linux kernel style:  /**

this comment is not a kdoc
there is not much left to make it one though, will do

> 
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>

thank you

> 
>> + * ice_vf_vsi_dis_single_rxq - disable a Rx queue for VF on relative
>> +queue ID
>> + * @vf: VF to disable queue for
>> + * @vsi: VSI for the VF
>> + * @q_id: VSI relative (0-based) queue ID
>> + *
>> + * Attempt to disable the Rx queue passed in. If the Rx queue was
>> +successfully
>> + * disabled then clear q_id bit in the enabled queues bitmap.
>> + */
>> +static int ice_vf_vsi_dis_single_rxq(struct ice_vf *vf, struct
>> ice_vsi *vsi,
>> +				     u16 q_id)
>> +{
>> +	int err;
>> +
>> +	if (!test_bit(q_id, vf->rxq_ena))
>> +		return 0;
>> +
>> +	err = ice_vsi_ctrl_one_rx_ring(vsi, false, q_id, true);
>> +	if (err) {
>> +		dev_err(ice_pf_to_dev(vsi->back), "Failed to stop Rx
>> ring %d on VSI %d\n",
>> +			q_id, vsi->vsi_num);
>> +		return err;
>> +	}
>> +
>> +	/* Clear enabled queues flag */
>> +	clear_bit(q_id, vf->rxq_ena);
>> +
>> +	return 0;
>> +}