From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 4/6] sh_eth: remove custom .nway_reset from ethtool ops Date: Sat, 26 May 2018 22:22:55 +0300 Message-ID: References: <1527160318-10958-1-git-send-email-vladimir_zapolskiy@mentor.com> <1527160318-10958-5-git-send-email-vladimir_zapolskiy@mentor.com> <919f9993-1a31-5b37-76aa-6268c6e686ba@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org To: Vladimir Zapolskiy , "David S. Miller" Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:52036 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032284AbeEZTW7 (ORCPT ); Sat, 26 May 2018 15:22:59 -0400 Received: by mail-wm0-f66.google.com with SMTP id j4-v6so22323615wme.1 for ; Sat, 26 May 2018 12:22:59 -0700 (PDT) In-Reply-To: <919f9993-1a31-5b37-76aa-6268c6e686ba@cogentembedded.com> Content-Language: en-MW Sender: netdev-owner@vger.kernel.org List-ID: On 05/26/2018 09:46 PM, Sergei Shtylyov wrote: >> The change fixes a sleep in atomic context issue, which can be >> always triggered by running 'ethtool -r' command, because >> phy_start_aneg() protects phydev fields by a mutex. > > Again, I'm unable to reproduce this BUG()... Now I can! I started to suspect this check needs to be specifically enabled under the Kernel Hacking menu, and it turned out to be so... >> Another note is that the change implicitly replaces phy_start_aneg() >> with a newer phy_restart_aneg(). >> >> Signed-off-by: Vladimir Zapolskiy > [...] MBR, Sergei