From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC82C17441 for ; Mon, 11 Nov 2019 14:30:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30A1421783 for ; Mon, 11 Nov 2019 14:30:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbfKKOaT (ORCPT ); Mon, 11 Nov 2019 09:30:19 -0500 Received: from www62.your-server.de ([213.133.104.62]:42786 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbfKKOaT (ORCPT ); Mon, 11 Nov 2019 09:30:19 -0500 Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1iUAhs-0000gH-V6; Mon, 11 Nov 2019 15:30:16 +0100 Received: from [2a02:1205:507e:bf80:bef8:7f66:49c8:72e5] (helo=pc-11.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1iUAhs-0005R7-IA; Mon, 11 Nov 2019 15:30:16 +0100 Subject: Re: [net-next PATCH] samples/bpf: adjust Makefile and README.rst To: Jesper Dangaard Brouer Cc: bpf@vger.kernel.org, linux-kbuild@vger.kernel.org, netdev@vger.kernel.org, Arnaldo Carvalho de Melo , Daniel Borkmann , Alexei Starovoitov References: <157340347607.14617.683175264051058224.stgit@firesoul> <20191111145628.23bea8fe@carbon> From: Daniel Borkmann Message-ID: Date: Mon, 11 Nov 2019 15:30:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20191111145628.23bea8fe@carbon> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25630/Mon Nov 11 10:59:49 2019) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/11/19 2:56 PM, Jesper Dangaard Brouer wrote: > On Mon, 11 Nov 2019 14:49:51 +0100 > Daniel Borkmann wrote: >> On 11/10/19 5:31 PM, Jesper Dangaard Brouer wrote: >>> Side effect of some kbuild changes resulted in breaking the >>> documented way to build samples/bpf/. >>> >>> This patch change the samples/bpf/Makefile to work again, when >>> invoking make from the subdir samples/bpf/. Also update the >>> documentation in README.rst, to reflect the new way to build. >>> >>> Signed-off-by: Jesper Dangaard Brouer >> >> Please make sure to have bpf@vger.kernel.org Cc'ed in future as well >> (done here). Given net-next in subject, any specific reason you need >> this expedited over normal bpf-next route? Looks like there is no >> conflict either way. > > When I created this patch, bpf-next didn't have the other fixes for > samples/bpf/. If you have sync'ed with net-next, then I'm fine with Correct, as they were just merged by Linus over the weekend. For bpf-next, we fast-fwd after every PR that is sent for net-next. For fixes the route is bpf -> net -> linus -> net-next -> bpf-next. > you taking this change (as it will propagate back to DaveM's tree soon > enough). Ok, I don't think the M= adjustment to get it back in line with the samples README is urgent, but lets go with net-next directly then and have it propagate back later this week, sent my Acked-by previously for carrying on. Thanks, Daniel