From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15FA1346798 for ; Fri, 10 Jul 2026 18:11:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783707106; cv=none; b=Uj6Ty7V6igf7157Rkmbl7lNKIe3cbzqG7wbvrXs5lY5YAiXdPcotVdYx0kq+JtUny4OyGF30PLn24WDambG9dM92Vfj5Jo6qU5hvy/LfbqorqGrr3vpR2b2zsVMI8k0bfdhAoCH8FG4VjVbjMMspbSAX++6jF2oNYtb79MZw/OU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783707106; c=relaxed/simple; bh=SRW1hyRy2MLVxxlmoOhn02LtikzideCrttxVVyIVT/w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lAOWfExZguN0tjaBMjUT4bD6sheHnxb9m0QGp2/w0EnQF2n8DAiBnGRU+4pAyk6nKXoGHigQWnDdwlIhrYacR1nZmjfHW3S1URfmpTusZdfi7K2AWLQ7Mb7Xe7MJDmpsPEGzArPEl5+sj5Llq0o2tzHNMBWlCZxqpbgWzPPUO00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fOc1Bbfz; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fOc1Bbfz" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-6983f20a8bfso1958345a12.1 for ; Fri, 10 Jul 2026 11:11:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783707103; x=1784311903; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=T+3p5jzJlBIxDNBN4ODBt7dUlm5yf6OTA6BJPqQx+TM=; b=fOc1BbfzcXFZ3xcyomRun0nZ7wDLl4nmOiwkQ6YZfyRfqEeDP8Ayx4oQouydXwOFan vPc70iPfrRU+3ve85y3mFUd0IlCAr6yHJa0R5InyfZaqkycT+GX1cGg+PzGcHrU0A9fv VJREi/MLAVVd1d3ABaqhVIGmSr7Bk2UiSPZpvk2BhakPmlJJx8bxjyYq97rADibiYt9p oJlyWqP7PXVoABlXy6OcO4oy9mJ74Je6oCyPMaguOdVLTN+ldDuV6TA2NYR7+AnG7URh DgEIWfwGu1aIOk/0eHR8FrmIgpilfG8Y0RGcnO9kl0QBGnvmwVq0Gv7N99jRTdJpvDzq wsVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783707103; x=1784311903; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T+3p5jzJlBIxDNBN4ODBt7dUlm5yf6OTA6BJPqQx+TM=; b=iLEMIZU/h8St6Z722THfQAwZM40VUd+VETOGlfqvZ0r8yT/3y/Ux7klbW5p4W5KU8C u0zLR6RHCPD70tvCU0j6Zhgvc52h8Ba4EVEvXqfE6/Ia1yLIA0J1HGf/lDTYKTO0rRqm AIynsAJ15d0Z02Sja8q7lmAnx4X2z4KFHUpn+MnI5E5JWKJj0ZNyCs0k5hewNLht8fy3 +E660IrPWp+5Jei7fU932W29FjJ+mPUL+CUsYvcTWqyZ76E6jJi/8/+NiKhzckwBUpFV yNN6yLn9PRkxP+WhKRZBMWhdOZyBIZWjE3MLGHvzyDnrh0/BeLtVVE6T1oG92N6Wk231 AQpg== X-Forwarded-Encrypted: i=1; AHgh+RrMBK+WDHHbj2UiXk0ClcF7zzbSWK/2yqmU0cedczdhanarGgxi7H0U47/gctNtpJhSTmUclj4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/Qry2lRwL75pCHn9pjm0HPAZUgTD5yIg5JkJK6iD1A/ztbbFY Ua9MAzxjxr9b8kycIUhBZpLXOn0gHULWDFGx0ewbrg1356UcxgR+dJRE X-Gm-Gg: AfdE7cl8VTItmeY1BD1kFEZNA844g+cppRG33K6P6cEwwrSkOLiL0FbDB8L9Q4upbjr xd8a/coktiC9SOSdKsM48293BcWZnF+jdbCnfNtknGtU7rHh3/aVCB9NnANxP5nVxNAm14oV+WB N5NoEhTa27S00GbHFsIqcGydavDSi08xRVhNidixjyind6STL42QNGf52XcNtBColOhs0qqBWHv 9/Krd5LbJ6zEuPl8aEJLDhgeoXkb3JHTaJfS/ELc9vBlqw1kswYUhIRx+8zLh+JqsU5iHTMyld6 ci9txJ2fim2PWJFkPAI2zHm/XazB/c+VZcyI+Kt2aYyVY3JJd83bhTbws7O74MPWdqNOoWP+LVB oMtb/k64Z2i6xXqRpcH2dvqpwslR+FZVHDZucyaJ/APtoWbBTj36jTOhPCTQFoaJvc5bxD77MfF dIzyF+7I2jaHoCfIzbRPBCH2m9Use3UH7POlqu/Y353jMYL8ZPpDy3uwExlP92yJ3ZUNZm304P5 75bnAoQmFOGmQXsQhFbZi8Mw2sPaL/ShAZEqNA3hUysE7osIKvin1yt+Srv95Q= X-Received: by 2002:a05:6402:40d0:b0:69a:bce:f1de with SMTP id 4fb4d7f45d1cf-69c5f22d500mr200285a12.26.1783707103268; Fri, 10 Jul 2026 11:11:43 -0700 (PDT) Received: from [192.168.0.2] (dslb-002-205-021-241.002.205.pools.vodafone-ip.de. [2.205.21.241]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69a19ce4b4fsm11209189a12.10.2026.07.10.11.11.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 11:11:41 -0700 (PDT) Message-ID: Date: Fri, 10 Jul 2026 20:11:40 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2 2/2] net: dsa: mv88e6xxx: flush the ATU when the hash algorithm changes To: Luke Howard , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vivien Didelot , Gregory CLEMENT , Andrew Lunn , Richard Cochran Cc: Cedric Jehasse , Kieran Tyrrell , Max Holtmann , Max Hunter , Christoph Mellauner , Simon Gapp , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260710-mv88e6x41-fixes-v2-0-e23654c65aa0@padl.com> <20260710-mv88e6x41-fixes-v2-2-e23654c65aa0@padl.com> Content-Language: en-US From: Jonas Gorski In-Reply-To: <20260710-mv88e6x41-fixes-v2-2-e23654c65aa0@padl.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 10/07/2026 01:29, Luke Howard wrote: > Changing the ATU hash algorithm invalidates existing entries: those > loaded under the previous algorithm end up in different bins and read > back corrupted. > > Flush the ATU whenever the hash algorithm is changed through devlink > and reload the default broadcast entries. Per-VLAN ATU entries and > any static addresses are not replayed, so the hash must be selected > before the FDB or MDB are configured. If changing the algorithm at runtime isn't handled fully and the hw AFAIU gets out of sync (i.e. static entries get lost from hw, but retained in the linux bridge), maybe it would make sense to reject changing it while e.g. a bridge exist? Feels like an easy foot-gun for hard to debug network issues. Best regards, Jonas