From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25777C433E7 for ; Mon, 19 Oct 2020 03:49:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6EB622282 for ; Mon, 19 Oct 2020 03:49:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RYt9d+az" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731684AbgJSDtf (ORCPT ); Sun, 18 Oct 2020 23:49:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731306AbgJSDtf (ORCPT ); Sun, 18 Oct 2020 23:49:35 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F336FC061755 for ; Sun, 18 Oct 2020 20:49:33 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id o9so4288257plx.10 for ; Sun, 18 Oct 2020 20:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:references:from:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yyMfIj+kU8+pqrQ/btCQJu8vMqR44MABK0jC++tcDuc=; b=RYt9d+azGgStnRt0SNLnN11Rr7nZcJ+Zg9OU0+R+m6nCqztUI3jPodgexIgCCTLtLF Pk5Rnx1ngzQ1STJRMte6/QS/w1iaLXooxdIMP6hCDfWKd964vczGIeeJeVIKbh8QARRe FIQKb+rE40JeAZjrGyJc7ukboR2OCDgkYY+e0AVyDLa4WHnerH6uzMkv5+tZtKZag5pX 3SbA+MplO2eITH3cwzw47VVFWP7glWIljFBfgA/huafNM66iLZFm0a+Q9SFSg+R0672r 3FaODC/WzSwgfg7J6UoYTL7myzEwgaKuWpdnbewVtIKBQHUGUOnJfz9flgGvChZU+5XW NtXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yyMfIj+kU8+pqrQ/btCQJu8vMqR44MABK0jC++tcDuc=; b=uaYEZK8Gszb/K2ES8G2+ID3LotjdiX5xVKRpRovaoAOg//Yu9VJ9vd090UfKmqAomp qAh+U6lZt+PA6Gdkrb+myjflLqVd2F1pEmvJqpCMQQ64Fj4rdrMDgX8cNSlnAbcsBbcH wZ2P9CDNiNrtB0aN+IgDjwdSGdO3UjL07ZTmCxd79lpiTk++hm1t2iu3E4MzZb4BDfT6 6h7einCiddlmP1PtJ8vF4py+MWPpFSd0PrttoxUqjeKninGnPCqAxPBiPCj8oJTIDT3K tfRN61GymB9Py66Em7dBUrur6jo5ySJl+EHJVAjxsE0Bdnd1VqBW5jGEXtjJMr+u550l f+jA== X-Gm-Message-State: AOAM533or3GuO9paO+heUSWpdqXZ8wOyfHkPS34ICGEFNngJWPcRaUXd tkY+1ecpcoD/I0xFY5TF3pA= X-Google-Smtp-Source: ABdhPJzr80C0rq9DtLuBQ3vH+ifwabUajKWBuOTbBACTCqGg6b9My0stJoF0DlBwCIU99zCCX372JA== X-Received: by 2002:a17:90b:717:: with SMTP id s23mr16217181pjz.122.1603079373524; Sun, 18 Oct 2020 20:49:33 -0700 (PDT) Received: from [10.230.29.112] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y5sm10652206pge.62.2020.10.18.20.49.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Oct 2020 20:49:32 -0700 (PDT) To: Vladimir Oltean Cc: Heiner Kallweit , "netdev@vger.kernel.org" , "andrew@lunn.ch" , "vivien.didelot@gmail.com" , "kuba@kernel.org" , Christian Eggers , Kurt Kanzenbach References: <20201017213611.2557565-1-vladimir.oltean@nxp.com> <20201017213611.2557565-2-vladimir.oltean@nxp.com> <06538edb-65a9-c27f-2335-9213322bed3a@gmail.com> <20201018121640.jwzj6ivpis4gh4ki@skbuf> <19f10bf4-4154-2207-6554-e44ba05eed8a@gmail.com> <20201018134843.emustnvgyby32cm4@skbuf> <2ae30988-5918-3d02-87f1-e65942acc543@gmail.com> <20201018225820.b2vhgzyzwk7vy62j@skbuf> <20201019002123.nzi2zhfak3r3lis3@skbuf> From: Florian Fainelli Subject: Re: [RFC PATCH 01/13] net: dsa: add plumbing for custom netdev statistics Message-ID: Date: Sun, 18 Oct 2020 20:49:31 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <20201019002123.nzi2zhfak3r3lis3@skbuf> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 10/18/2020 5:21 PM, Vladimir Oltean wrote: > On Sun, Oct 18, 2020 at 04:11:14PM -0700, Florian Fainelli wrote: >> How about when used as a netconsole? We do support netconsole over DSA >> interfaces. > > How? Who is supposed to bring up the master interface, and when? > You are right that this appears not to work when configured on the kernel command line: [ 6.836910] netpoll: netconsole: local port 4444 [ 6.841553] netpoll: netconsole: local IPv4 address 192.168.1.10 [ 6.847582] netpoll: netconsole: interface 'gphy' [ 6.852305] netpoll: netconsole: remote port 9353 [ 6.857030] netpoll: netconsole: remote IPv4 address 192.168.1.254 [ 6.863233] netpoll: netconsole: remote ethernet address b8:ac:6f:80:af:7e [ 6.870134] netpoll: netconsole: device gphy not up yet, forcing it [ 6.876428] netpoll: netconsole: failed to open gphy [ 6.881412] netconsole: cleaning up looking at my test notes from 2015 when it was added, I had only tested dynamic netconsole while the network devices have already been brought up which is why I did not catch it. Let me see if I can fix that somehow. -- Florian