From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF27AC4360F for ; Tue, 26 Feb 2019 04:26:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD72521841 for ; Tue, 26 Feb 2019 04:26:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PcnJSbFh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726382AbfBZE0P (ORCPT ); Mon, 25 Feb 2019 23:26:15 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:41549 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726012AbfBZE0P (ORCPT ); Mon, 25 Feb 2019 23:26:15 -0500 Received: by mail-pf1-f195.google.com with SMTP id d25so5568213pfn.8 for ; Mon, 25 Feb 2019 20:26:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XqbLKBUj6xH1a+9xHnUsCjx91P9j7lAo+Qovx5xsg+0=; b=PcnJSbFhUh2X5jHG64SyArfjtzzd89fIANCmhNMmrrOAcNmYJFZm+j+tlnmpRI2Zaj tYZMXRfhJ8p6sHgZSJjpquoI9SdMyl1klv2rT7Rei4LNZlfA81xuCPP8kQwKf3kiPSOg 0Md5KuAoZbXAzpknmWnmijkpaaW6czCoPl0V27GdlPW8rp1XfsQOxJT/JlqK0xC3zsvR AFyS3KkLZTSm2zpdVC+mc4vZdefuShAZyKcnjmw7HO3aXiRCiMDXHe+Y+gz6M7xh6v0w bmU3y5VyTDZvvreqXGV2Gu+9B9bzPq+eyttNhp29Y1/zgkN0XAu8Hs5xWl37/kuqpDQl ioTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=XqbLKBUj6xH1a+9xHnUsCjx91P9j7lAo+Qovx5xsg+0=; b=h4qatu4l9UBrYdPSacErNcHUkjoyxXx8RxwgrRv/z0yFpFzGrF3Q7EsnmJez4E4h7l 1HtKr0+wQg1QZWF1S/hcYjLA1HE51x6zFwBgA5M7bhI3MTn3N1Xd1NVb/J7+Rvtx9VJG n2SdNC6f1j1EfRBuYUa7D3FAXXvfTc3tNo3J4K1UuPpelp0ebpo1UcDkeqVQzw0nde9h 5PngqW+rnOoUXPUcJDlF/zQ8N87QilsXW99XCV9XDt8ARRIleFenpZj+UY5tWoysw2YH oigxbDntsIyCuqm2bXtUHtu1G5YGYN9G2MSaJzbHj3HT9eR09OQUShECO9HqpcYJAIBt 0xkg== X-Gm-Message-State: AHQUAuaflM6kJZv6Y8v54RlX36VfThoXLFV4hK17YD3gQMmN8a6yR0sv f28oPZ52Rshu/1eMcRgnYnJ1WKsX X-Google-Smtp-Source: AHgI3IYNyKMDKbnoogoBpPlAl0LfgUaauW10P+aSUywBIdnE8SMtSxWXoRPNynTJ4e+uDc0qvh4BPA== X-Received: by 2002:a62:fc10:: with SMTP id e16mr24220145pfh.83.1551155173989; Mon, 25 Feb 2019 20:26:13 -0800 (PST) Received: from [10.230.28.107] ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id l7sm28414462pfj.162.2019.02.25.20.26.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 20:26:12 -0800 (PST) Subject: Re: [PATCH net-next v4 5/6] devlink: hold a reference to the netdevice around ethtool compat To: Jakub Kicinski , davem@davemloft.net, jiri@resnulli.us Cc: mkubecek@suse.cz, andrew@lunn.ch, netdev@vger.kernel.org, oss-drivers@netronome.com References: <20190226033407.32625-1-jakub.kicinski@netronome.com> <20190226033407.32625-6-jakub.kicinski@netronome.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; keydata= mQENBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAG0KEZsb3JpYW4gRmFpbmVsbGkgPGZhaW5lbGxpQGJyb2FkY29tLmNvbT6JAccEEAECALEF AlPAG9YXCgABv0jL/n0t8VEFmtDa8j7qERo7AN0gFAAAAAAAFgABa2V5LXVzYWdlLW1hc2tA cGdwLmNvbY4wFIAAAAAAIAAHcHJlZmVycmVkLWVtYWlsLWVuY29kaW5nQHBncC5jb21wZ3Bt aW1lCAsJCAcDAgEKAhkBBReAAAAAGRhsZGFwOi8va2V5cy5icm9hZGNvbS5jb20FGwMAAAAD FgIBBR4BAAAABBUICQoACgkQgTG1xCm8ZqD+Dgf9HhhzqvJYIPomNeg+ll7/TbzWb871E+HQ TaufJQFQwLEbgdFSZO2uj4UqfDpCyTwtHTVMJogWt3pCAE1sadeIY8OlT6918ofKIl8AiHj2 BlfL7ASZ5wzkRMt/4TZoinq9O1tPEynb5G6PdZTV3UQtmSGnpt2EOu7KtRJsnThBiXoOO9TJ Asg4vXJ0ZM1y/MPhQlZbPCHQZFe1gaVWBPLGnLyWyeprqgSLWHaGqrUhlfK1sLuJK1bjYDCI NetK0pS4cA4ZJgogr5FrtV64R19zLl02mt/Yj7rAmjC3ZBuwVi3V35kD8Kd4d9QM2apsiILV bzGbtVCSUgvxI+1SsJEm3bkBDQRTwBvBAQgArGvvWip77T4xgJztZp9YRylAcVTC9gtx0Gg6 eYk/EPANGm9TkuGpI++T/Il2H2TjFQNC7eubWohbYj0+6Tmf8nP+VmyobDxPXcMrK7x4xy9o D+Kub2Vf0SXbsM8fL/SqzGbFWZSm73L1L4GZoxvYIz0i7LExYSX2u5YVLaMBaH9HwKt2cvr7 MuTrRHtcbOZImoXT29g2UnoF1uwxYNeRhZY/lRvVkkY0lDipPuDwg3SpfHMtCybPq1uAswQd gEbHzRsEXwCR1OF3pIuGt4I3tSEhH/k1caqi0BlqjbGUOkku44xC2gf1ZU267FBBkdV3yJ/7 KnrJEnkMCYhS3kII9wARAQABiQJBBBgBAgErBQJTwBvCBRsMAAAAwF0gBBkBCAAGBQJTwBvB AAoJEJNgBqiYLw9VDRUIAJaTef6hsUAESnlGDpC+ymL2RZdzAJx9lXjU4hhaFcyhznuyyMJq d3mehmLxsqDRvHDiqyD71w2Bnc838MVZw0pwBPdnb/h9Ocmp0lL/9hwSGWvy4az5lYVyoA9u 14UIzh0YNGu6jr0isd/LJAbHXqwJwWWs3y8PTrpEp68V6lv+aXt5gR03lJEAvIR1Awp4JJ/e Z5y12gQISp0X8xal9YhhDWER92YLYrO2b6Hc2S31lAupzfCw8lmZsP1PRz1GmF/KmDD9J9N/ b8IehhWQqrBQjMjn2K2XkvN75HnAMHKFYfHZR3ZHtK52ZP1crV7THtbtrnPXVDq+vO4QPmdC +SEACgkQgTG1xCm8ZqC6BwgAl3kRh7oozpjpG8jpO8en5CBtTl3G+OpKJK9qbQyzdCsuJ0K1 qe1wZPZbP/Y+VtmqSgnExBzjStt9drjFBK8liPQZalp2sMlS9S7csSy6cMLF1auZubAZEqpm tpXagbtgR12YOo57Reb83F5KhtwwiWdoTpXRTx/nM0cHtjjrImONhP8OzVMmjem/B68NY++/ qt0F5XTsP2zjd+tRLrFh3W4XEcLt1lhYmNmbJR/l6+vVbWAKDAtcbQ8SL2feqbPWV6VDyVKh ya/EEq0xtf84qEB+4/+IjCdOzDD3kDZJo+JBkDnU3LBXw4WCw3QhOXY+VnhOn2EcREN7qdAK w0j9Sw== Message-ID: Date: Mon, 25 Feb 2019 20:26:06 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190226033407.32625-6-jakub.kicinski@netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/25/2019 7:34 PM, Jakub Kicinski wrote: > When ethtool is calling into devlink compat code make sure we have > a reference on the netdevice on which the operation was invoked. > > v3: move the hold/lock logic into devlink_compat_* functions (Florian) > > Signed-off-by: Jakub Kicinski Reviewed-by: Florian Fainelli -- Florian